[PATCH] don't reallocate sxp variable passed into xfs_swapext

Christoph Hellwig hch at infradead.org
Mon Jan 26 01:46:36 CST 2009


On Sun, Jan 25, 2009 at 08:53:00PM -0600, Eric Sandeen wrote:
> fixes kernel.org bugzilla 12538, xfs_fsr fails on 2.6.29-rc kernels
> 
> Regression caused by 743bb4650da9e2595d6cedd01c680b5b9398c74a
> 
> This was an embarrasing mistake, reallocating the sxp pointer passed
> in from the main ioctl switch.
> 
> Signed-off-by: Eric Sandeen <sandeen at sandeen.net
> Reported-by: Paul Martin <pm at debian.org>
> Tested-by: Paul Martin <pm at debian.org>

Yikes.  Looks good to me, but any chance you could try cooking up a
xfsqa test that would hit this as our existing xfs_fsr test apparently
doesn't?


Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list