[XFS updates] XFS development tree branch, for-linus, updated. v2.6.28-rc3-11554-g74e2d06
xfs at oss.sgi.com
xfs at oss.sgi.com
Thu Jan 22 16:21:31 CST 2009
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".
The branch, for-linus has been updated
74e2d06 Long btree pointers are still 64 bit on disk
from b6e3222732a3551e786aa47b90a8eab2a517711c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 74e2d06521913443c7e2697037909f5efc200ec5
Author: Dave Chinner <david at fromorbit.com>
Date: Wed Jan 21 15:22:17 2009 +1100
Long btree pointers are still 64 bit on disk
[XFS] Long btree pointers are still 64 bit on disk
On 32 bit machines with CONFIG_LBD=n, XFS reduces the
in memory size of xfs_fsblock_t to 32 bits so that it
will fit within 32 bit addressing. However, the disk format
for long btree pointers are still 64 bits in size.
The recent btree rewrite failed to take this into account
when initialising new btree blocks, setting sibling pointers
to NULL and checking if they are NULL. Hence checking whether
a 64 bit NULL was the same as a 32 bit NULL was failingi
resulting in NULL sibling pointers failing to be detected
correctly. This showed up as WANT_CORRUPTED_GOTO shutdowns
in xfs_btree_delrec.
Fix this by making all the comparisons and setting of long
pointer btree NULL blocks to the disk format, not the
in memory format. i.e. use NULLDFSBNO.
Reported-by: Alexander Beregalov <a.beregalov at gmail.com>
Reported-by: Jacek Luczak <difrost.kernel at gmail.com>
Reported-by: Danny ter Haar <dth at dth.net>
Tested-by: Jacek Luczak <difrost.kernel at gmail.com>
Reviewed-by: Christoph Hellwig <hch at infradead.org>
Signed-off-by: Dave Chinner <david at fromorbit.com>
Signed-off-by: Felix Blyakher <felixb at sgi.com>
-----------------------------------------------------------------------
Summary of changes:
fs/xfs/xfs_btree.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
hooks/post-receive
--
XFS development tree
More information about the xfs
mailing list