[PATCH] [XFS] Warn on transaction in flight on read-only remount
hch at infradead.org
Thu Jan 22 00:27:03 CST 2009
On Thu, Jan 22, 2009 at 12:10:15AM -0600, Felix Blyakher wrote:
> [resending after fixing xfs mailing list on oss]
> Just wanted to point out to discussion on this topic:
> I merely took a suggestion from it, and put it in a patch.
Did you actually test it? WARN_ON has an inverted sense over
ASSERT/ASSERT_ALWAYS, so this would trigger all the time.
>> + /* Just warn here till VFS can correctly support
>> + * read-only remount without racing.
>> + */
Also this should be:
I also have a VFS -level patch somewhere to prevent further writers to
occur during a remount in a rather hacky way, but I'd rather have a
testcase to reproduce this reliably before sending it to Al.
More information about the xfs