[PATCH 1/2] xfs: fix error handling in xfs_log_mount

Christoph Hellwig hch at infradead.org
Wed Feb 11 16:39:23 CST 2009


On Wed, Feb 11, 2009 at 10:24:37AM +1100, Lachlan McIlroy wrote:
> I'd prefer both fixes go in so we have maximum defence against
> this problem happening again but I'm really not fussed.

I disagree.  All these weird error checks for things that can't happen
just make the code big, bloated and unreadable.  And they make people
sloppy by not enforcing the same unwind order thus leading to more
bugs (as seen by the historic xfs mount path before we started unwinding
it)




More information about the xfs mailing list