> wouldn't NULL be a better error return for this kind of interface, > matching kmalloc? I guess returning an error code from memdup_user() lets callers distinguish between ENOMEM and EFAULT. Not sure if that's important or not but there probably are at least some sites that care. - R.