[patch 06/12] Make the bulkstat_one compat ioctl handling more sane

Christoph Hellwig hch at infradead.org
Wed Nov 26 04:33:33 CST 2008


On Tue, Nov 25, 2008 at 09:20:11PM -0600, sandeen at sandeen.net wrote:
> Currently the compat formatter was handled by passing
> in "private_data" for the xfs_bulkstat_one formatter,
> which was really just another formatter... IMHO this
> got confusing.
> 
> Instead, just make a new xfs_bulkstat_one_compat
> formatter for xfs_bulkstat, and call it via a wrapper.
> 
> Also, don't translate the ioctl nrs into their native
> counterparts, that just clouds the issue; we're in a
> compat handler anyway, just switch on the 32-bit cmds.

Looks good.



More information about the xfs mailing list