[patch 07/12] Fix xfs_bulkstat_one size checks & error handling
Christoph Hellwig
hch at infradead.org
Wed Nov 26 04:34:47 CST 2008
On Tue, Nov 25, 2008 at 09:20:12PM -0600, sandeen at sandeen.net wrote:
> The 32-bit xfs_blkstat_one handler was failing because
> a size check checked whether the remaining (32-bit)
> user buffer was less than the (64-bit) bulkstat buffer,
> and failed with ENOMEM if so. Move this check
> into the respective handlers so that they check the
> correct sizes.
>
> Also, the formatters were returning negative errors
> or positive bytes copied; this was odd in the positive
> error value world of xfs, and handled wrong by at least
> some of the callers, which treated the bytes returned
> as an error value. Move the bytes-used assignment
> into the formatters
Looks good.
More information about the xfs
mailing list