[PATCH] fix xfsqa on whole disks

Christoph Hellwig hch at infradead.org
Mon Nov 24 22:22:59 CST 2008


mkfe2fs unfortunately hasn't heard about real enterprise setups using
whole disks and needs the -F option to create a filesystem on those
without asking stupid questions that make the testcases block forever.


Signed-off-by: Christoph Hellwig <hch at lst.de>

Index: xfstests/032
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/032,v
retrieving revision 1.14
diff -u -p -r1.14 032
--- xfstests/032	29 May 2008 17:01:09 -0000	1.14
+++ xfstests/032	25 Nov 2008 04:18:59 -0000
@@ -46,6 +46,10 @@ do
 	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
 	# cramfs mkfs requires a directory argument
 	[ $fs = cramfs ] && preargs=/proc/fs/xfs
+	[ $fs = ext2 ] && preargs="-F"
+	[ $fs = ext3 ] && preargs="-F"
+	[ $fs = ext4 ] && preargs="-F"
+	[ $fs = ext4dev ] && preargs="-F"
 
 	# overwite the first few Kb - should blow away superblocks
 	src/devzero -n 20 $SCRATCH_DEV >/dev/null
Index: xfstests/049
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/049,v
retrieving revision 1.16
diff -u -p -r1.16 049
--- xfstests/049	29 Jun 2007 06:16:22 -0000	1.16
+++ xfstests/049	25 Nov 2008 04:18:59 -0000
@@ -60,7 +60,7 @@ echo "--- mounts" >> $seq.full
 mount >> $seq.full
 
 _log "Create ext2 fs on scratch"
-mkfs -t ext2 $SCRATCH_DEV >> $seq.full 2>&1 \
+mkfs -t ext2 -F $SCRATCH_DEV >> $seq.full 2>&1 \
     || _fail "!!! failed to mkfs ext2"
 
 _log "Mount ext2 fs on scratch"



More information about the xfs mailing list