[patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler
Christoph Hellwig
hch at infradead.org
Wed Nov 19 09:16:28 CST 2008
On Tue, Nov 18, 2008 at 10:44:10PM -0600, sandeen at sandeen.net wrote:
> +extern int
> +xfs_attrmulti_attr_get(struct inode *, char *, char __user *,
> + __uint32_t *, __uint32_t);
> +extern int
> +xfs_attrmulti_attr_set(struct inode *, char *, const char __user *,
> + __uint32_t, __uint32_t);
> +extern int
> +xfs_attrmulti_attr_remove(struct inode *, char *, __uint32_t);
These should be in a header.
> + if (copy_from_user(&am_hreq, arg, sizeof(compat_xfs_fsop_attrmulti_handlereq_t)))
> + return -XFS_ERROR(EFAULT);
> +
> + error = xfs_vget_fsop_handlereq_compat(mp, parinode, &am_hreq.hreq, &inode);
Far too long lines, please break them up after 80 chars.
Looks good even if the duplication is rather sad..
More information about the xfs
mailing list