[PATCH 2/3 v4] Add new flags to getbmapx interface

Christoph Hellwig hch at infradead.org
Wed Nov 12 03:22:36 CST 2008


On Wed, Oct 29, 2008 at 11:58:44AM -0500, Eric Sandeen wrote:
> Add new getbmap flags.
> 
> This adds a new output flag, BMV_OF_LAST to indicate if we've hit
> the last extent in the inode.  This potentially saves an extra call
> from userspace to see when the whole mapping is done.
> 
> It also adds BMV_IF_DELALLOC and BMV_OF_DELALLOC to request, and
> indicate, delayed-allocation extents.  In this case bmv_block
> is set to -2 (-1 was already taken for HOLESTARTBLOCK; unfortunately
> these are the reverse of the in-kernel constants.)
> 
> These new flags facilitate addition of the new fiemap interface.
> 
> Rather than adding sh_delalloc, remove sh_unwritten & just test
> the flags directly.

Looks good.



More information about the xfs mailing list