[PATCH 1/5] xfstests: fix compiler warnings
Eric Sandeen
sandeen at sandeen.net
Tue Dec 30 19:59:11 CST 2008
Christoph Hellwig wrote:
(hmm we need to teach quilt not to do attachments...)
...
> Index: xfstests/src/looptest.c
> ===================================================================
> --- xfstests/src/looptest.c 2008-12-30 14:51:21.000000000 +0000
> +++ xfstests/src/looptest.c 2008-12-30 14:51:31.000000000 +0000
> @@ -28,8 +28,6 @@
>
> /* dxm - 28/2/2 */
>
> -#define _GNU_SOURCE
> -
> #include <stdio.h>
> #include <stdlib.h>
> #include <malloc.h>
...
Just in case this gets transplanted outside xfstests, where _GNU_SOURCE
may not be defined on the make commandline, would it make sense to just
put this #define inside
#ifndef _GNU_SOURCE?
Just a thought; otherwise looks good to me.
-Eric
More information about the xfs
mailing list