[Fwd: [PATCH] Fix race in xfs_write() between direct and buffered I/O with DMAPI]

Christoph Hellwig hch at infradead.org
Tue Dec 23 02:40:13 CST 2008


On Tue, Dec 23, 2008 at 11:40:24AM +1100, Lachlan McIlroy wrote:
> Christoph Hellwig wrote:
> > Do you need more input on this one?
> 
> Actually I just might.  Based on your last reponse I wasn't sure if
> you wanted me to make further changes.

Well, my reponse was that I think we could do it more effecient, but the
patch still looks correct to me.

> Then I got side-tracked wondering
> why we even have the 'goto retry' in the dmapi post event - why retry the
> write if we get ENOSPC when we don't if dmapi is not enabled?  Could the
> write get stuck in an infinite loop?

We only retry on ENOSPC if the dmapi nospace even is enabled, or am I
missing something?




More information about the xfs mailing list