couple small xfstest patches

Christoph Hellwig hch at infradead.org
Mon Dec 22 07:08:24 CST 2008


On Fri, Nov 21, 2008 at 01:45:23PM -0800, Matthew Kent wrote:
> * 189 fails with external devices
> * add a unified diff output option, find it easier on the eyes ;)

Thanks, I'll put these into my queue.  Question to the list:  any
arguments against just making unified diffs the default for xfsqa
output?

> 
> Thanks!
> -- 
> Matthew Kent <mkent at magoazul.com>
> http://magoazul.com
> --- xfs-cmds/xfstests/common.orig	2008-11-21 13:19:47.000000000 -0800
> +++ xfs-cmds/xfstests/common	2008-11-21 13:22:04.000000000 -0800
> @@ -107,7 +107,7 @@
>      -nfs                test NFS
>      -l			line mode diff (default)
>      -xdiff		graphical mode diff
> -    -diffu		show unified diff
> +    -udiff		show unified diff
>      -n			show me, do not run tests
>      -q			quick [deprecated]
>      -T			output timestamps
> @@ -158,7 +158,7 @@
>  	    fi
>  	    ;;
>  
> -	-diffu)	# show unified diff
> +	-udiff)	# show a unified diff
>  	    xpand=false
>  	    diff="$diff -u"
>  	    ;;
> --- xfs-cmds/xfstests/189.orig	2008-11-21 13:43:33.000000000 -0800
> +++ xfs-cmds/xfstests/189	2008-11-21 13:42:48.000000000 -0800
> @@ -188,8 +188,8 @@
>  _need_to_be_root
>  _require_scratch
>  
> -unset SCRATCH_OPTIONS
> -unset MOUNT_OPTIONS
> +unset SCRATCH_RTDEV
> +unset SCRATCH_LOGDEV
>  
>  _scratch_mkfs_xfs | _filter_mkfs 2>/dev/null
>  
> _______________________________________________
> xfs mailing list
> xfs at oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

---end quoted text---




More information about the xfs mailing list