[PATCH] Check return value of xfs_buf_get_noaddr()

[Lachlan McIlroy]

Eric Sandeen wrote:
> Lachlan McIlroy wrote:
>> We check the return value of all other calls to xfs_buf_get_noaddr().
>> Make sense to do it here too.
>>
>> --- a/fs/xfs/xfs_vnodeops.c
>> +++ b/fs/xfs/xfs_vnodeops.c
>> @@ -3034,6 +3034,8 @@ xfs_zero_remaining_bytes(
>>   	bp = xfs_buf_get_noaddr(mp->m_sb.sb_blocksize,
>>   				XFS_IS_REALTIME_INODE(ip) ?
>>   				mp->m_rtdev_targp : mp->m_ddev_targp);
>> +	if (!bp)
>> +		return ENOMEM;
> 
> Maybe
> 
> +		return XFS_ERROR(ENOMEM);
Okay.  Will do.

> 
> -Eric
> 
>>   	for (offset = startoff; offset <= endoff; offset = lastoffset + 1) {
>>   		offset_fsb = XFS_B_TO_FSBT(mp, offset);
>>
>> _______________________________________________
>> xfs mailing list
>> xfs at oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>>
> 
>