[PATCH] Remove unused variable in ktrace_free()

Eric Sandeen sandeen at sandeen.net
Thu Dec 4 09:29:35 CST 2008


Lachlan McIlroy wrote:
> entries_size is probably left over from when we used to pass the
> size to kmem_free().

Reviewed-by: Eric Sandeen <sandeen at sandeen.net>

> --- xfs-fix.orig/fs/xfs/support/ktrace.c
> +++ xfs-fix/fs/xfs/support/ktrace.c
> @@ -113,21 +113,16 @@ ktrace_alloc(int nentries, unsigned int
>   void
>   ktrace_free(ktrace_t *ktp)
>   {
> -	int     entries_size;
> -
>   	if (ktp == (ktrace_t *)NULL)
>   		return;
> 
>   	/*
>   	 * Special treatment for the Vnode trace buffer.
>   	 */
> -	if (ktp->kt_nentries == ktrace_zentries) {
> +	if (ktp->kt_nentries == ktrace_zentries)
>   		kmem_zone_free(ktrace_ent_zone, ktp->kt_entries);
> -	} else {
> -		entries_size = (int)(ktp->kt_nentries * sizeof(ktrace_entry_t));
> -
> +	else
>   		kmem_free(ktp->kt_entries);
> -	}
> 
>   	kmem_zone_free(ktrace_hdr_zone, ktp);
>   }
> 
> _______________________________________________
> xfs mailing list
> xfs at oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 




More information about the xfs mailing list