[xfs-masters] [Bug 109291] The system cannot enter any suspend state.

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=109291

Dave Chinner <david at fromorbit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at fromorbit.com

--- Comment #1 from Dave Chinner <david at fromorbit.com> ---
The xfsaild is already idle and not running - it won't run again until some
activity in the filesystem wakes it up again. Hence the xfsaild will never call
try_to_freeze() and be frozen by the freezer.

This looks like a bug in the freezer algorithm, not XFS. Likely caused by this
change in 4.4-rc1:

commit 24ba16bb3d499c49974669cd8429c3e4138ab102
Author: Jiri Kosina <jkosina at suse.cz>
Date:   Mon Nov 2 13:46:58 2015 +1100

    xfs: clear PF_NOFREEZE for xfsaild kthread

    Since xfsaild has been converted to kthread in 0030807c, it calls
    try_to_freeze() during every AIL push iteration. It however doesn't set
    itself as freezable, and therefore this try_to_freeze() will never do
    anything.

    Before (hopefully eventually) kthread freezing gets converted to fileystem
    freezing, we'd rather mark xfsaild freezable (as it can generate I/O
    during suspend).

    Signed-off-by: Jiri Kosina <jkosina at suse.cz>
    Reviewed-by: Brian Foster <bfoster at redhat.com>
    Signed-off-by: Dave Chinner <david at fromorbit.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.