[xfs-masters] request for verbose mount

[Eric Sandeen]

On 3/29/11 2:33 AM, Gono, Pavol wrote:
> Hi
>  
> I was trying to mount XFS filesystem with options sunit + swidth, and I learned filesystem must be aligned at the mkfs time. But I was irritated that there is no error message in kernel log after unsuccessful mount:
>  
> # mount -txfs -osunit=128,swidth=512 /dev/hda12 /mnt/hda12
> mount: wrong fs type, bad option, bad superblock on /dev/hda12,
>        missing codepage or helper program, or other error
>        In some cases useful info is found in syslog - try
>        dmesg | tail  or so
> # mount -txfs -osunit=8,swidth=32 /dev/hda12 /mnt/hda12
> #
>  
> Could you add explanation messages to the mounting code if anything fails?
> Attached is example patch.
>  
> Pavol Gono
> 

"XFS: alignment check N failed" has always been rather unhelpful, IMHO.

Changing them all to something descriptive & helpful sounds good to me,
as does making sure every EINVAL mount failure says -something- useful.

-Eric