[xfs-masters] [Bug 846] New: xfs_metadump fails to properly hash obfuscated invalid names

bugzilla-daemon at oss.sgi.com bugzilla-daemon at oss.sgi.com
Thu Aug 13 11:54:52 CDT 2009


http://oss.sgi.com/bugzilla/show_bug.cgi?id=846

           Summary: xfs_metadump fails to properly hash obfuscated invalid
                    names
           Product: XFS
           Version: unspecified
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P5
         Component: xfsprogs
        AssignedTo: xfs-masters at oss.sgi.com
        ReportedBy: sandeen-xfs at sandeen.net
   Estimated Hours: 0.0
    Classification: Unclassified


Not sure if this qualifies as a bug, but if a filename in a directory looks
like "/blah" for example (see bug 845) then xfs_metadump fails to create a
hash-equivalent name when obfuscating.  This makes metadump a bit less useful
for analyzing this sort of corrupted fs.

This can easily be demonstrated by using xfs_db to overwrite the first char of
any dir entry with "/" and then running xfs_metadump:

db/xfs_db -F -i -p xfs_metadump -c 'metadump  /tmp/md' /dev/sdb3
xfs_db: metadump.c:470: generate_obfuscated_name: Assertion
`xfs_da_hashname(newname, namelen) == hash' failed.

If possible we should probably (?) properly hash even invalid names.

Or, perhaps the original hashing function won't touch this name either in which
case the point is moot, and it's a combination of corrupt name & already
invalid hash so there's no point.

But it bears some investigation I think.

-- 
Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the xfs-masters mailing list