linux-next: xfs tree build failure

[Stephen Rothwell]

Hi Dave,

On Thu, 30 Oct 2008 20:08:32 +1100 Dave Chinner <david at fromorbit.com> wrote:
>
> On Thu, Oct 30, 2008 at 01:23:24PM +1100, Stephen Rothwell wrote:
> > 
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > 
> > ERROR: "inode_wait" [fs/xfs/xfs.ko] undefined!
> > 
> > Caused by commit 676a7711ee281c3bf41db18e29e296584de82793 ("[XFS] Fix
> > race when looking up reclaimable inodes") which introduced a use of
> > wait_on_inode() which is an inline that calls inode_wait().
> 
> Putting a non-exported symbol in an inline function in a header file
> that is full of exported functions.  That's pretty anti-social. ;)
> 
> > I applied the following patch (probably wrong :-)).
> 
> I think it's probably the only solution - we need to wait until
> the I_LOCK bit is cleared from the inode and AFAICT wait_on_inode()
> is the only way to do it.

Any resolution?

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://oss.sgi.com/pipermail/xfs-masters/attachments/20081105/ec144c31/attachment.pgp