[pcp] Client Certificates

[Martins Innus]

Nathan,

On 5/20/16 3:04 AM, Nathan Scott wrote:
> Hi Martins,
>
> ----- Original Message -----
>> Nathan,
>> 	OK, hopefully getting close here.
>>
>
> Definitely, its looking good.  I've put a martins-merge branch on github
> which has your latest - I had to resolve a minor numbering conflict with
> your new test.  I'm also now wondering if /etc/pcp/nssdb might be better
> than /var/lib/pcp/config/nssdb - not sure.

OK, I can change it.  Just let me know.


> I'm seeing a few new failures; I've attached the .bads (these all reliably
> passed without the new code).  Anything stand out as immediately obvious?
> All look like probably the same underlying problem - I can take a closer
> look early next week if not obvious, they're reproducible here.

This is an issue with my QA changes.

Not sure why it was working before (I have the bash history that implies 
it did), but this patch is now needed and those QA tests pass for me. 
Without it, the "-Q" was being added in all cases.

diff --git a/qa/common.secure b/qa/common.secure
index e24b83d..29ee28e 100644
--- a/qa/common.secure
+++ b/qa/common.secure
@@ -139,7 +139,7 @@ nss_setup_collector()
         $sudo chown -R pcp:pcp $collectordb
      fi

-    if [ -n $force_client_cert ]
+    if [ -n "$force_client_cert" ]
      then
         cert_option="-Q"
      fi


Thanks

Martins