[pcp] pcp (pcp4 branch) updates

Ken McDonell kenj at internode.on.net
Mon Feb 27 03:23:26 CST 2012


Move along, move along, nothing to see here ...

Pulling the dev branch into the pcp4 branch.

Changes committed to git://oss.sgi.com/kenj/pcp.git pcp4
(note this is the pcp4 branch)

 GNUmakefile                                  |    1 
 build/GNUmakefile                            |    4 
 build/rpm/pcp.spec.in                        |    5 
 configure.in                                 |   82 +
 dev/null                                     |binary
 man/.gitignore                               |    2 
 man/man1/chkhelp.1                           |   21 
 man/man1/dbpmda.1                            |    8 
 man/man1/pmdasample.1                        |    2 
 man/man1/pmdasendmail.1                      |    2 
 man/man1/pmdasimple.1                        |    2 
 man/man1/pmdatrivial.1                       |    2 
 man/man1/pmdatxmon.1                         |    2 
 man/man3/pmerrstr.3                          |   27 
 man/man3/pmnewcontext.3                      |   42 
 src/cpan/GNUmakefile                         |    2 
 src/cpan/Glider/GNUmakefile                  |   33 
 src/cpan/Glider/Glider.bat                   |   43 
 src/cpan/Glider/Glider.pm                    |  381 --------
 src/cpan/Glider/LaunchExe.pm                 |  154 ---
 src/cpan/Glider/LaunchScript.pm              |  154 ---
 src/cpan/Glider/README                       |  204 ----
 src/cpan/Glider/WiX.patch                    |   38 
 src/cpan/Glider/pcp.fstab                    |    1 
 src/cpan/Glider/pcp.profile                  |   14 
 src/cpan/Glider/pcpsh.bat                    |   15 
 src/cpan/Glider/postinst.bat                 |   35 
 src/cpan/Glider/prerm.bat                    |   28 
 src/cpan/LogImport/Makefile.PL               |    8 
 src/cpan/MMV/Makefile.PL                     |    8 
 src/cpan/PMDA/Makefile.PL                    |    8 
 src/cpan/PMDA/PMDA.pm                        |    2 
 src/cpan/PMDA/PMDA.xs                        |    3 
 src/dbpmda/src/dso.c                         |   16 
 src/dbpmda/src/gram.y                        |    2 
 src/dbpmda/src/pmda.c                        |   32 
 src/include/.gitignore                       |    4 
 src/include/GNUmakefile                      |   27 
 src/include/builddefs.in                     |   32 
 src/include/fault.h                          |   55 -
 src/include/impl.h                           | 1245
---------------------------
 src/include/import.h                         |   67 -
 src/include/mk_pmdbg                         |   62 -
 src/include/mmv_dev.h                        |   84 -
 src/include/mmv_stats.h                      |  107 --
 src/include/pcp/.gitignore                   |    4 
 src/include/pcp/GNUmakefile                  |   46 
 src/include/pcp/fault.h                      |   55 +
 src/include/pcp/impl.h                       | 1237
++++++++++++++++++++++++++
 src/include/pcp/import.h                     |   67 +
 src/include/pcp/mk_pmdbg                     |   62 +
 src/include/pcp/mmv_dev.h                    |   84 +
 src/include/pcp/mmv_stats.h                  |  107 ++
 src/include/pcp/platform_header.h.in         |  611 +++++++++++++
 src/include/pcp/platform_trailer.in          |   14 
 src/include/pcp/pmafm.h                      |   51 +
 src/include/pcp/pmapi.h                      |  728 +++++++++++++++
 src/include/pcp/pmda.h                       |  571 ++++++++++++
 src/include/pcp/pmiestats.h                  |   41 
 src/include/pcp/pmimport.h                   |   52 +
 src/include/pcp/pmtime.h                     |  111 ++
 src/include/pcp/trace.h                      |  116 ++
 src/include/pcp/trace_dev.h                  |   99 ++
 src/include/pcp/trace_hash.h                 |   66 +
 src/include/platform_header.h.in             |  623 -------------
 src/include/platform_trailer.in              |   14 
 src/include/pmafm.h                          |   51 -
 src/include/pmapi.h                          |  733 ---------------
 src/include/pmda.h                           |  571 ------------
 src/include/pmiestats.h                      |   41 
 src/include/pmimport.h                       |   51 -
 src/include/pmtime.h                         |  111 --
 src/include/trace.h                          |  116 --
 src/include/trace_dev.h                      |   99 --
 src/include/trace_hash.h                     |   66 -
 src/libpcp/src/GNUmakefile                   |   22 
 src/libpcp/src/auxconnect.c                  |   18 
 src/libpcp/src/check-statics                 |  311 ++++++
 src/libpcp/src/config.c                      |    3 
 src/libpcp/src/connect.c                     |   18 
 src/libpcp/src/connectlocal.c                |   18 
 src/libpcp/src/context.c                     |    1 
 src/libpcp/src/derive.c                      |  102 +-
 src/libpcp/src/derive.h                      |    1 
 src/libpcp/src/derive_fetch.c                |    4 
 src/libpcp/src/err.c                         |  123 +-
 src/libpcp/src/events.c                      |   12 
 src/libpcp/src/fault.c                       |   17 
 src/libpcp/src/fetch.c                       |   10 
 src/libpcp/src/fetchlocal.c                  |   14 
 src/libpcp/src/interp.c                      |  138 +-
 src/libpcp/src/ipc.c                         |   10 
 src/libpcp/src/logconnect.c                  |   18 
 src/libpcp/src/logmeta.c                     |   16 
 src/libpcp/src/logportmap.c                  |   30 
 src/libpcp/src/logutil.c                     |   88 +
 src/libpcp/src/loop.c                        |    2 
 src/libpcp/src/optfetch.c                    |   21 
 src/libpcp/src/p_lcontrol.c                  |    1 
 src/libpcp/src/p_pmns.c                      |   22 
 src/libpcp/src/p_result.c                    |   11 
 src/libpcp/src/pdu.c                         |   25 
 src/libpcp/src/pdubuf.c                      |    5 
 src/libpcp/src/pmns.c                        |  113 +-
 src/libpcp/src/profile.c                     |    4 
 src/libpcp/src/spec.c                        |    2 
 src/libpcp/src/units.c                       |    8 
 src/libpcp/src/util.c                        |   96 +-
 src/libpcp/src/win32.c                       |    2 
 src/libpcp_fault/src/GNUmakefile             |    8 
 src/libpcp_gui/src/record.c                  |    4 
 src/libpcp_http/src/http_fetcher.c           |    6 
 src/libpcp_pmda/src/cache.c                  |   15 
 src/libpcp_pmda/src/mainloop.c               |    1 
 src/libpcp_pmda/src/queues.c                 |  143 +--
 src/libpcp_pmda/src/tree.c                   |    4 
 src/newhelp/chkhelp.c                        |  200 ++--
 src/pmcd/rc-proc.sh                          |    8 
 src/pmcd/src/config.c                        |   34 
 src/pmcd/src/dopdus.c                        |   18 
 src/pmcd/src/dostore.c                       |    2 
 src/pmcd/src/pmcd.c                          |    7 
 src/pmdas/GNUmakefile                        |    4 
 src/pmdas/bonding/.gitignore                 |    2 
 src/pmdas/cisco/probe.c                      |    9 
 src/pmdas/cisco/telnet.c                     |    7 
 src/pmdas/dbping/.gitignore                  |    4 
 src/pmdas/elasticsearch/.gitignore           |    2 
 src/pmdas/elasticsearch/pmdaelasticsearch.pl |    5 
 src/pmdas/etw/.gitignore                     |    5 
 src/pmdas/etw/GNUmakefile                    |   24 
 src/pmdas/etw/event.c                        |  256 ++++-
 src/pmdas/etw/event.h                        |   10 
 src/pmdas/etw/help                           |   32 
 src/pmdas/etw/pmda.c                         |  131 +-
 src/pmdas/etw/pmns                           |   12 
 src/pmdas/etw/tdhconsume.c                   |  232 +++--
 src/pmdas/etw/tdhlist.c                      |   30 
 src/pmdas/etw/util.c                         |    4 
 src/pmdas/freebsd/GNUmakefile                |   69 +
 src/pmdas/freebsd/disk.c                     |  208 ++++
 src/pmdas/freebsd/freebsd.c                  |  973
+++++++++++++++++++++
 src/pmdas/freebsd/freebsd.h                  |   44 
 src/pmdas/freebsd/help                       |   95 ++
 src/pmdas/freebsd/netif.c                    |  225 ++++
 src/pmdas/freebsd/root_freebsd               |  165 +++
 src/pmdas/gpsd/.gitignore                    |    2 
 src/pmdas/kvm/.gitignore                     |    2 
 src/pmdas/linux/cgroups.c                    |   17 
 src/pmdas/linux/interrupts.c                 |    2 
 src/pmdas/linux/ksym.c                       |   19 
 src/pmdas/linux/pmda.c                       |    9 
 src/pmdas/linux/proc_meminfo.c               |    2 
 src/pmdas/linux/proc_net_snmp.c              |    2 
 src/pmdas/linux/proc_net_sockstat.c          |    2 
 src/pmdas/linux/proc_net_tcp.c               |    1 
 src/pmdas/linux/proc_partitions.c            |    2 
 src/pmdas/linux/proc_pid.c                   |   12 
 src/pmdas/linux/proc_scsi.c                  |    1 
 src/pmdas/linux/proc_slabinfo.c              |   45 
 src/pmdas/linux/proc_stat.c                  |    5 
 src/pmdas/linux/proc_vmstat.c                |    2 
 src/pmdas/logger/event.c                     |    9 
 src/pmdas/logger/logger.c                    |    2 
 src/pmdas/lustrecomm/.gitignore              |    1 
 src/pmdas/lustrecomm/GNUmakefile             |    7 
 src/pmdas/lustrecomm/libreadfiles.h          |    6 
 src/pmdas/lustrecomm/refresh_file.c          |    4 
 src/pmdas/memcache/.gitignore                |    2 
 src/pmdas/mmv/.gitignore                     |    1 
 src/pmdas/mmv/GNUmakefile                    |    7 
 src/pmdas/mmv/mmvdump.c                      |    5 
 src/pmdas/mounts/mounts.c                    |   16 
 src/pmdas/mysql/.gitignore                   |    2 
 src/pmdas/named/.gitignore                   |    2 
 src/pmdas/netfilter/.gitignore               |    2 
 src/pmdas/news/.gitignore                    |    2 
 src/pmdas/pdns/.gitignore                    |    2 
 src/pmdas/postfix/.gitignore                 |    2 
 src/pmdas/postgresql/.gitignore              |    2 
 src/pmdas/postgresql/pmdapostgresql.pl       |   68 +
 src/pmdas/process/process.c                  |   14 
 src/pmdas/roomtemp/.gitignore                |    1 
 src/pmdas/roomtemp/GNUmakefile               |    7 
 src/pmdas/rsyslog/.gitignore                 |    2 
 src/pmdas/rsyslog/pmdarsyslog.pl             |    2 
 src/pmdas/samba/.gitignore                   |    2 
 src/pmdas/sample/src/percontext.c            |   15 
 src/pmdas/sample/src/sample.c                |   17 
 src/pmdas/sendmail/sendmail.c                |    1 
 src/pmdas/simple/.gitignore                  |    1 
 src/pmdas/simple/GNUmakefile                 |    7 
 src/pmdas/snmp/.gitignore                    |   11 
 src/pmdas/snmp/GNUmakefile                   |   55 +
 src/pmdas/snmp/Install                       |   55 -
 src/pmdas/snmp/README                        |  108 +-
 src/pmdas/snmp/Remove                        |   33 
 src/pmdas/snmp/pmdabonding.pl                |  306 +++---
 src/pmdas/snmp/pmdasnmp.pl                   | 1008
+++++++++++++++------
 src/pmdas/snmp/sample.config                 |   38 
 src/pmdas/snmp/snmp.conf                     |   94 +-
 src/pmdas/systemtap/.gitignore               |    2 
 src/pmdas/trace/.gitignore                   |    2 
 src/pmdas/trace/GNUmakefile                  |   32 
 src/pmdas/trace/GNUmakefile.stub             |   30 
 src/pmdas/trace/app2.c                       |    1 
 src/pmdas/trace/app3.c                       |    1 
 src/pmdas/trace/src/pmda.c                   |    4 
 src/pmdas/trace/src/trace.c                  |    3 
 src/pmdas/trivial/.gitignore                 |    1 
 src/pmdas/trivial/GNUmakefile                |    7 
 src/pmdas/txmon/.gitignore                   |    1 
 src/pmdas/txmon/GNUmakefile                  |    7 
 src/pmdas/vmware/.gitignore                  |    2 
 src/pmdas/weblog/server.sh                   |    8 
 src/pmdas/weblog/weblog.c                    |  163 +--
 src/pmdas/weblog/weblog.h                    |    2 
 src/pmdas/windows/.gitignore                 |    1 
 src/pmdas/windows/GNUmakefile                |    3 
 src/pmdas/windows/pmda.c                     |   57 -
 src/pmdas/zimbra/.gitignore                  |    2 
 src/pmie/src/dstruct.c                       |    2 
 src/pmie/src/eval.c                          |    7 
 src/pmie/src/lexicon.c                       |   61 -
 src/pmie/src/pmie.c                          |    5 
 src/pmie/src/show.c                          |    2 
 src/pmie/src/symbol.c                        |    9 
 src/pmie/src/syslog.c                        |    3 
 src/pmieconf/pmieconf.c                      |    8 
 src/pmieconf/rules.c                         |   68 -
 src/pmieconf/rules.h                         |    2 
 src/pmimport/iostat2pcp/.gitignore           |    2 
 src/pmimport/mrtg2pcp/.gitignore             |    2 
 src/pmimport/sar2pcp/.gitignore              |    2 
 src/pmimport/sheet2pcp/.gitignore            |    2 
 src/pmlogextract/logio.c                     |   12 
 src/pmlogextract/metriclist.c                |    4 
 src/pmlogextract/pmlogextract.c              |   33 
 src/pmlogger/callback.c                      |    4 
 src/pmlogger/check.c                         |    4 
 src/pmlogger/dopdu.c                         |   27 
 src/pmlogger/fetch.c                         |    4 
 src/pmlogger/gram.y                          |    8 
 src/pmlogger/logger.h                        |    1 
 src/pmlogger/pmlogger.c                      |    4 
 src/pmlogger/preamble.c                      |   46 
 src/pmlogreduce/dometric.c                   |    7 
 src/pmlogreduce/indom.c                      |   33 
 src/pmlogreduce/pmlogreduce.c                |   26 
 src/pmlogreduce/pmlogreduce.h                |    7 
 src/pmlogreduce/scan.c                       |    6 
 src/pmlogrewrite/indom.c                     |   14 
 src/pmlogrewrite/lex.l                       |    1 
 src/pmlogrewrite/logio.c                     |    4 
 src/pmlogrewrite/metric.c                    |   16 
 src/pmlogrewrite/pmlogrewrite.c              |   32 
 src/pmlogrewrite/result.c                    |   10 
 src/pmlogrewrite/util.c                      |   12 
 src/pmlogsummary/pmlogcheck.c                |   12 
 src/pmlogsummary/pmlogsummary.c              |   26 
 src/pmns/pmnsutil.c                          |    7 
 src/pmns/stdpmid.pcp                         |    4 
 src/pmval/pmval.c                            |    7 
 src/win32ctl/include/evntprov.h              |    2 
 src/win32ctl/include/evntrace.h              |    2 
 src/win32ctl/include/guiddef.h               |  165 ---
 266 files changed, 9821 insertions(+), 7215 deletions(-)

commit cddd1eee6fbe4b2bb49190162cec3b2a22323955
Merge: be1210f fa35fdc
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 27 20:19:12 2012 +1100

    Merge branch 'dev' into pcp4

commit fa35fdc05e338c16f074919c39325527d5c1f9fd
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 27 11:49:32 2012 +1100

    PCP::PMDA man page correction
    
    Fix SEE ALSO -> pcpintro(3) not pmda(3).

commit 8aa6de1263c762ade370c51458e8495f7ebf86ad
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 27 11:47:46 2012 +1100

    pmNewContext man page - document extended host syntax
    
    Provide an example of the extended syntax
        host[:port1[,...]][@firewall:port2[,...]] syntax
    from __pmParseHostSpec() that is understood by pmNewContext().

commit cc3db208c1cecfd114caefc7631815ca5d446ebe
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 27 07:23:52 2012 +1100

    some pmda man pages - fix man indexing
    
    Using pmda\*(ia is just fine in most places _except_ in the line
    after the NAME macro, which is used to build the man index ...
    prior to this change, "man pmda" produced a random pmda man page!

commit be1210f13fb50dbd9155ee740fd7e85b46b0214e
Merge: a2b731b e9b497b
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 24 21:06:40 2012 +1100

    Merge branch 'dev' into pcp4

commit e9b497b7cdf213ccf6a20518879fad56dd6b650f
Merge: d61cadc 6b81ad7
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 24 21:06:17 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev

commit 6b81ad7e00d9b6b33a2042127f4743e24b93e825
Author: Nathan Scott <nathans at debian.org>
Date:   Wed Feb 22 14:35:11 2012 +1100

    Trivial cleanup in some sample PMDA event code.

commit f5ae443b829401a78a816e4e8b0415935cc52924
Author: Nathan Scott <nathans at debian.org>
Date:   Wed Feb 22 14:34:45 2012 +1100

    logger.numclients metric is of instantaneous type, not discrete

commit 2e950d4adde7970e0fc5e3193b7cca50e94b766c
Author: Nathan Scott <nathans at debian.org>
Date:   Wed Feb 22 14:31:17 2012 +1100

    Fix issues in latest event queue interfaces
    
    This addresses three issues, mainly from the last round of
    event queue interface additions:
    - The return code of several helper routines was inconsistent
      with the QueueRecords fetch routine and as a result wrong
      return codes from fetch would be returned.  Resulted in a
      few no-values returns instead of the actual values.
    - the global event client count was looking at only the first
      client instead of all, thanks to a pointer bug, and would
      have returned incorrect values (if not obscured by another
      issue, above).
    - Leaking context memory, due to incorrect check to see if
      a context exists and is in use rather than always allocing
      a new one.  (this bug has actually been there for awhile)

commit a2b731beb05bda601199f6cad28fe2f873639c78
Merge: 5b2a492 d61cadc
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 20 17:22:38 2012 +1100

    Merge branch 'dev' into pcp4

commit d61cadc122976ec4b3f0d78800e64a91271fb72b
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 20 17:18:12 2012 +1100

    snmp PMDA - add snmp.conf to the source inventory
    
    Fixes a Makepkgs failure.

commit 5b2a49281c90ace082623a59832be2eecbb7a0dc
Merge: b279990 e175ede
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 20 15:01:15 2012 +1100

    Merge branch 'dev' into pcp4

commit e175ede7f3f615ffddcc1a7a18ce970073dd5f6e
Merge: 272d96d f2aec63
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 20 15:00:58 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev

commit 272d96d931a3307e3c82a46f414038a64e47ddd2
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 20 14:58:30 2012 +1100

    weblog - server.sh
    
    Fix obscure gawk RE problem associated with {...}

commit b279990d6f92984c350cefc41351adedd318bd5b
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 20 06:44:53 2012 +1100

    pmcd - PMDA negotiation buffer pinning fix
    
    Fallout from previous __pmUnpinPDUBuf() change in AgentNegotiate()
    as part of the PCP 4.0 changes.  The logic here was wrong and we
were
    calling __pmUnpinPDUBuf() with a bogus buffer address on the
end-of-file
    error case (exposed by QA 427), which was finally caught by the
addition
    of the assert() in __pmUnpinPDUBuf() as part of commit 3534fbb.

commit f2aec6326a1ed6b301dcf62a541fb1a862b4798e
Author: Nathan Scott <nathans at debian.org>
Date:   Sat Feb 18 13:38:01 2012 +1100

    Fix couple of typos and a minor perl pod issue in pmdasnmp.1

commit 5171069a626c6fa1bdb062a97cd80340b97dc88b
Author: Nathan Scott <nathans at debian.org>
Date:   Sat Feb 18 11:07:42 2012 +1100

    Add generated man page to gitignore list for SNMP agent.

commit b681ca93dbb61af15e296a4161a6a2f7add1c78f
Merge: 3cf2169 3950c26
Author: Nathan Scott <nathans at debian.org>
Date:   Sat Feb 18 11:05:39 2012 +1100

    Merge branch 'master' of git://wob.zot.org/9/pcp into dev
    
    Conflicts:
    	src/pmdas/GNUmakefile

commit 3cf21696c2ad824614f1c5e0d9836fff4f38cf9b
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Feb 17 15:13:07 2012 +1100

    Additional postgresql recovery and xlog status metrics.

commit 1993a88974e688c8375bf7f5ce735ba91489e016
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 17 13:39:36 2012 +1100

    libpcp_fault - minor changes to allow build to complete again
    
    Fixing bit rot.

commit f208d11d48b81ff4a250b622c2feb845e17fd0f0
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 17 13:32:24 2012 +1100

    fault.h - one more header to relocate
    
    Fallout from dev branch changes moving headers to src/include/pcp

commit f8c9dfab62c2cfb9431cd787a894ef63b07dca17
Merge: ac24e39 8d3309c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 17 12:42:29 2012 +1100

    Merge branch 'dev' into pcp4
    
    Normal sorts of merge conflict ... mostly thread-safe changes
overlapping
    with Coverity changes.
    
    Conflicts:
    	src/dbpmda/src/dso.c
    	src/dbpmda/src/pmda.c
    	src/include/GNUmakefile
    	src/include/builddefs.in
    	src/libpcp/src/derive.c
    	src/libpcp/src/interp.c
    	src/libpcp/src/logportmap.c
    	src/libpcp/src/logutil.c
    	src/libpcp/src/optfetch.c
    	src/libpcp/src/pdubuf.c
    	src/libpcp/src/pmns.c
    	src/libpcp/src/profile.c
    	src/libpcp/src/util.c
    	src/pmlogger/preamble.c

commit 2a0fecc5f9cf80194f08b0a7f7b03e088824ba4d
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Feb 17 12:29:40 2012 +1100

    Build system related fixups to the ETW PMDA.

commit 6207a69a4a9721022590e4bd049248610aad391a
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Feb 17 12:27:59 2012 +1100

    Fix up oversight in windows gitignore, libpdh long since moved.

commit a00de929f40302d0a4d367ab63ad1d4d46d739f2
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Feb 17 12:27:14 2012 +1100

    Remove references to mips_o32 in dbpmda man page.

commit 8d3309c9923b5bc977065f134819c6a0d2d5cad7
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Feb 14 20:38:10 2012 +1100

    pmlogger - fix last Coverity fix that was botched
    
    Thanks goodness for PCP QA!

commit ce414af466c7c7db8042942b192d968e66b19d0e
Merge: 62b2750 210a220
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Feb 14 10:15:24 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev

commit 210a220c1dc9c8438ebf1f8f30ea5a3aaf9c0ffb
Author: Nathan Scott <nathans at debian.org>
Date:   Tue Feb 14 09:51:54 2012 +1100

    Small cosmetic code consistency cleanup in dbpmda.

commit 62b2750bf4127cdb5395b8954c873a8c8e0f3d1e
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Feb 14 06:18:57 2012 +1100

    lustrecomm PMDA - compilation warning
    
    Fix fallout from Coverity-driven changes.

commit 229ef5ba11abd31b2ac1f49113763c916034dd4a
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 13 20:54:29 2012 +1100

    pmlogrewrite/util.c - resource_leak
    Original Coverity cases #209, #215 and #228
    http://people.redhat.com/mgoodwin/pcp-cov/1/209util.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/215util.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/228util.c.html#error
    
    Add missing free() calls for locally malloc'd storage, and
closedir()
    at end of loop.

commit f4916b4a07ea02b4d7f977d8046a3dd9fe07c2ef
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 13 20:46:12 2012 +1100

    pmlogrewrite/pmlogrewrite.c - resource_leak
    Original Coverity case #188

http://people.redhat.com/mgoodwin/pcp-cov/1/188pmlogrewrite.c.html#error
    
    Add closedir() after opendir().

commit cbd7b1669ae5f40d5ce3af7d4579c2933797d0ca
Author: Nathan Scott <nathans at debian.org>
Date:   Mon Feb 13 12:41:07 2012 +1100

    Fix two Coverity-found memleaks in dbpmda fetch logic (#249 & #250).

commit adaca37edd36c24a8df62d589acdb6ed53e55cb8
Author: Nathan Scott <nathans at debian.org>
Date:   Mon Feb 13 10:57:24 2012 +1100

    Clarify some unclear dbpmda code, after earlier Coverity fix.

commit c58206c94a2317d4c586a2b53ac5f2331b7478f7
Author: Nathan Scott <nathans at debian.org>
Date:   Mon Feb 13 10:53:32 2012 +1100

    Remove dead code found by coverity in dbpmda (issue #56).

commit ac18e14f713a4e5d24225e5f0c7280cd3fb08b04
Author: Nathan Scott <nathans at debian.org>
Date:   Mon Feb 13 10:50:43 2012 +1100

    Remove dead code found by coverity in dbpmda (issue #52).

commit 33879bfe3aaa51ef46c453148a636f11aacd6f7a
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 13 06:39:36 2012 +1100

    pmlogrewrite/logio.c - resource_leak
    Original Coverity cases #185 and #201
    http://people.redhat.com/mgoodwin/pcp-cov/1/185logio.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/201logio.c.html#error
    
    Rework the freeing of memory on the error branches.

commit 8b7efb018317677ce8f753ef2f5c5581563e0e63
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 13 06:32:30 2012 +1100

    pmlogrewrite/logio.c - negative_returns
    Original Coverity case #112.
    http://people.redhat.com/mgoodwin/pcp-cov/1/112logio.c.html#error
    
    In the place where we use the results from ftell() in a subsequent
call
    to fseek(), add an assert() to ensure the ftell() result is >= 0 ...
the
    error case should not happen and is only expected by Coverity!

commit efee6ca98ecc825ed41976fbbd37b91286add357
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Feb 13 06:20:35 2012 +1100

    pmlogrewrite/util.c - assorted Coverity fixes
    Original Coverity cases #45, #49 and #53.
    http://people.redhat.com/mgoodwin/pcp-cov/1/45util.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/49util.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/53util.c.html#error
    
    For some reason, Coverity fails to understand that control does
    not return from abandon(), but only in the util.c source file.
    
    Added /*NOTREACHED*/ annotation after each abandon() call to
    reinforce the fact that control will not reach here.

commit 86eff7837ad1b7b718158e3e77df1c949fa53619
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sun Feb 12 07:40:24 2012 +1100

    pmlogrewrite/pmlogrewrite.c - negative_returns
    Original Coverity cases #87, #88 and #89.

http://people.redhat.com/mgoodwin/pcp-cov/1/87pmlogrewrite.c.html#error

http://people.redhat.com/mgoodwin/pcp-cov/1/88pmlogrewrite.c.html#error

http://people.redhat.com/mgoodwin/pcp-cov/1/89pmlogrewrite.c.html#error
    
    In all the places where we use the results from ftell() in a
    subsequent call to fseek(), add an assert() to ensure the ftell()
    result is >= 0 ... the error cases should not happen and are only
    expected by Coverity!

commit 8bb13046200eaa46a5cdc6a12b016bf9c69c5e51
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sun Feb 12 07:32:09 2012 +1100

    pmlogrewrite/indom.c - sizeof_mismatch
    Original Coverity cases #285 and #286.
    http://people.redhat.com/mgoodwin/pcp-cov/1/285indom.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/286indom.c.html#error
    
    Minor rewrite, no real change.

commit 8fda1611f639ae8fe081e36bfae1953db497e641
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sun Feb 12 07:14:17 2012 +1100

    pmlogrewrite/metric.c - assorted Coverity fixes
    Original Coverity cases #55, #252, #283, #284 and #306.
    http://people.redhat.com/mgoodwin/pcp-cov/1/55metric.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/252metric.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/283metric.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/284metric.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/306metric.c.html#error
    
    Fixing a number of minor issues where Coverity analysis is correct,
    but for various reasons the bugs are benign.

commit a7d00a55aff54a1b786a7e4a0453dc8b758aeffb
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 11 17:12:01 2012 +1100

    pmlogextract/pmlogextract.c - unused_value
    Original Coverity case #308.

http://people.redhat.com/mgoodwin/pcp-cov/1/308pmlogextract.c.html#error
    
    Remove variable and pointless assignment.

commit ed4f552420655ac6f6e17c8a44d4a9c62e022138
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 11 17:05:34 2012 +1100

    pmlogextract/pmlogextract.c - reverse_inull
    Original Coverity cases #262 and #265.

http://people.redhat.com/mgoodwin/pcp-cov/1/262pmlogextract.c.html#error

http://people.redhat.com/mgoodwin/pcp-cov/1/265pmlogextract.c.html#error
    
    Clean up the handling of iap->_result.

commit 21467c780e1924fb3bda01affdaa381360e94576
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 11 07:18:57 2012 +1100

    pmlogextract/metriclist.c - reverse_inull
    Original Coverity case #253.

http://people.redhat.com/mgoodwin/pcp-cov/1/253metriclist.c.html#error
    
    Check for NULL _before_ deref, duh.

commit 02301f86ee4db2555676e1ab4ec6bdaa9d82fb52
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 11 07:12:46 2012 +1100

    pmlogextract/logio.c - resource_leak
    Original Coverity cases #187 and #199.
    http://people.redhat.com/mgoodwin/pcp-cov/1/187logio.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/199logio.c.html#error
    
    free() malloc'd buffer on error paths.

commit 76f80b37cf06a75369bf2146b2c5bf04f30388c8
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 11 07:05:50 2012 +1100

    pmlogextract/logio.c - negative_returns
    Original Coverity case #110.
    http://people.redhat.com/mgoodwin/pcp-cov/1/110logio.c.html#error
    
    In the place where we use the results from ftell() in a subsequent
call
    to fseek(), add an assert() to ensure the ftell() result is >= 0 ...
the
    error case should not happen and is only expected by Coverity!

commit 8ae0a407de12e8cbbba3d0128dd52c0c22edb824
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 11 06:58:10 2012 +1100

    pmlogextract/pmlogextract.c - negative_returns
    Original Coverity cases #92, #93, #94 and #108.

http://people.redhat.com/mgoodwin/pcp-cov/1/92pmlogextract.c.html#error

http://people.redhat.com/mgoodwin/pcp-cov/1/93pmlogextract.c.html#error

http://people.redhat.com/mgoodwin/pcp-cov/1/94pmlogextract.c.html#error

http://people.redhat.com/mgoodwin/pcp-cov/1/108pmlogextract.c.html#error
    
    In all the places where we use the results from ftell() in a
    subsequent call to fseek(), add an assert() to ensure the ftell()
    result is >= 0 ... the error cases should not happen and are only
    expected by Coverity!

commit ce603bc11a8d4726acc0bc7b44f949ab3399f6e9
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 10 09:45:24 2012 +1100

    pmie/dstruct.c - uninit
    Original Coverity case #297
    http://people.redhat.com/mgoodwin/pcp-cov/1/297dstruct.c.html#error
    
    Explicitly initialize local pmUnits struct.

commit 2f1b769cd8a69b473108a755e3c13e4ae6725337
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 10 09:32:13 2012 +1100

    pmie/symbol.c - reverse_inull
    Original Coverity case #258
    http://people.redhat.com/mgoodwin/pcp-cov/1/258symbol.c.html#error
    
    Tighten guard.

commit 008b050c47a21af920958427f98a93a258420207
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 10 07:39:52 2012 +1100

    pmie/pmie.c - resource_leak
    Original Coverity case #231
    http://people.redhat.com/mgoodwin/pcp-cov/1/231pmie.c.html#error
    
    Add free() for Coverity, although this is not really needed because
the
    next call is exit() in main()!

commit f36f18c572189681b2098fb85628b65eb2c77da2
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 10 07:03:28 2012 +1100

    pmie/syslog.c - resource_leak
    Original Coverity case #143
    http://people.redhat.com/mgoodwin/pcp-cov/1/143syslog.c.html#error
    
    sdup() not needed here.

commit 12413c272ab043d2a4ae377bb600c264ebf2b187
Merge: 72ce76d ecd476f
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 10 06:19:09 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev

commit 72ce76ddabdf9e10475ded307c517aedde2034ff
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Feb 9 16:07:48 2012 +1100

    RPM spec file - remove verbose diagnostics
    
    Whatever problem this was debugging has either been fixed or has
moved on.

commit b2f0388deffaaf4c8e9e98a4f3eecd76633e68f7
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Feb 9 10:47:49 2012 +1100

    Rearrange headers in the source tree
    
    These changes allow all of PCP to be built in an environment where
    /usr/include/pcp does not exist and there are no PCP libraries in
    /usr/lib* ... so everything PCP-related that used in the build comes
    out of the PCP source tree.
    
    Further, the references to the PCP headers are consistent
throughout.
    If the source file is included in the binary package (by way of an
    example or demo), then the form
    	#include <pcp/pmapi.h>
    is used to match the man pages.  Otherwise (for the vast majority of
    files) the form
    	#include "pmapi.h"
    is used.
    
    This style rule applies to all the PCP headers, not just pmapi.h.
    
    With these changes, Mark's chroot build issue should be resolved.
    
    Also in this commit, Perl build (Makefile.PL) changes to remove the
    	Note (probably harmless): No library found for ...
    messages when PCP libraries are not installed in /usr/lib* ... these
    messages would not stop the build, but DID produce bad Perl modules
    with unresolved symbols ... I've seen the messages in some of the QA
    environments (but probably only for the first build!), and now
    understand what they mean!!
    
    Nathan, a similar Perl build fix needs to be made for the Mingw
builds
    that I cannot test at the moment.

commit ecd476f74b42ccb067f1582aaa30e295896406eb
Author: Nathan Scott <nathans at debian.org>
Date:   Wed Feb 8 17:36:15 2012 +1100

    Add event capture and queueing logic to pmdaetw.
    
    Event queues reader and writers are now protected from each other.
    Initial work to ensure event can be decoded (delayed from initial
    event receipt) is now in place as well.

commit 2348bc272be5d2b2f80076925b112f67e68cda2a
Author: Ken McDonell <kenj at internode.on.net>
Date:   Wed Feb 8 13:59:12 2012 +1100

    pmie/lexicon.c - missing_break
    Original Coverity case #79
    http://people.redhat.com/mgoodwin/pcp-cov/1/79lexicon.c.html#error
    
    There was no issue here, the control never passed to the "missing"
    break was never executed.  However cleaned up the code a little to
    improve readability and replace some literal numeric constants by
    local symbolic constants.

commit c45540fb3a8952721a3d94a73af9062d32293bfb
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sun Feb 5 07:14:59 2012 +1100

    pmie/eval.c - missing_break
    Original Coverity case #78
    http://people.redhat.com/mgoodwin/pcp-cov/1/78eval.c.html#error
    
    Cases in question (x->op == NULL and x->op == OP_VAR) can never
    happen, so the missing break; was benign ... removed the dead code
    and added a comment to explain.

commit d23043be5e90f5fa8344458a60eb62a19fd79f96
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sun Feb 5 06:23:27 2012 +1100

    pmie/show.c - forward_null
    Original Coverity case #64
    http://people.redhat.com/mgoodwin/pcp-cov/1/64show.c.html#error
    
    Code was correct, added an assert() to reinforce the fact that
    x->arg1 is not NULL in the unary operator case.

commit b593f25a7365f018286e2d9becf83b09413ec816
Merge: bb71c70 3069f55
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 4 14:35:53 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev

commit 3069f551ae5d74fd665f3e3e4dd35e034471b84c
Author: Nathan Scott <nathans at debian.org>
Date:   Sat Feb 4 12:55:08 2012 +1100

    Fix error message memory leak in pmval parsing time window.

commit 39a774243d4807dd51a3a19bbf5e96a4bda82b65
Author: Nathan Scott <nathans at debian.org>
Date:   Sat Feb 4 12:53:35 2012 +1100

    Fix pmresult leak in error paths of fetch loop of pmval.

commit f6a96ba552956b7de0955f6df9ef94bfcd7ec9ce
Author: Nathan Scott <nathans at debian.org>
Date:   Sat Feb 4 11:55:51 2012 +1100

    Fix several memory leaks on error paths in pmieconf.

commit bb71c70bce2bae662cc0cc5bb4cb639233fdee06
Merge: 42e5c46 183e6da
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 4 11:20:55 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev

commit 42e5c468542cbf31b6aeb231ccfed7e547641e25
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 4 07:12:32 2012 +1100

    pmlogger/dopdu.c - use_after_free
    Original Coverity case #322
    http://people.redhat.com/mgoodwin/pcp-cov/1/322dopdu.c.html#error
    
    Yep, a real bug this time.

commit 1ce5353799984c869a8431b2b5dffab971ada235
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 4 07:00:15 2012 +1100

    pmlogger/fetch.c - resource_leak
    Original Coverity case #162
    http://people.redhat.com/mgoodwin/pcp-cov/1/162fetch.c.html#error
    
    No real problem here (newlist is not set in __dmprefetch() if newcnt
    <= numpmid on return) ... cosmetic code rearrangement to try and
stop
    Coverity complaining.

commit fd0c0ba0bb4e60e7488d90418fe9e5a1489daabe
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 4 06:51:28 2012 +1100

    pmlogger/preamble.c - resource_leak
    Original Coverity cases #158 and #232
    http://people.redhat.com/mgoodwin/pcp-cov/1/158preamble.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/232preamble.c.html#error
    
    Rework the freeing of memory on the error branches.

commit 2c9ea484ff5be1dfaaf4dfa4d12c3d5b24633191
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 4 06:40:10 2012 +1100

    pmlogger/pmlogger.c - resource_leak
    Original Coverity case #150
    http://people.redhat.com/mgoodwin/pcp-cov/1/150pmlogger.c.html#error
    
    After calling pmParseInterval(), free(errmsg) in success.

commit 5612bbd1431e0bf155989881f53155059eccbd72
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 4 06:31:11 2012 +1100

    pmlogger/callback.c - negative_returns
    Original Coverity cases #96, #97 and #114.
    http://people.redhat.com/mgoodwin/pcp-cov/1/96pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/97pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/114pmns.c.html#error
    
    In all the places where we use the results from ftell() in a
subsequent
    call to fseek(), add an assert() to ensure the ftell() result is >=
    0 ... the error cases should not happen and are only expected by
Coverity!

commit bcf0c68ef883fbeb3f36c5896cddd5c847d662f9
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Feb 4 06:19:28 2012 +1100

    pmlogger/dopdu.c - forward_null
    Original Coverity case #46
    http://people.redhat.com/mgoodwin/pcp-cov/1/46dopdu.c.html#error
    
    Code was correct, added an assert() to reinforce the fact that
    hp is not null after the __pmHashSearch() loop.

commit bc1f2d946267a1906272c1dd85022d4a85cff1ae
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Feb 3 20:34:18 2012 +1100

    pmlogger/check.c - checked_return
    Original Coverity case #11
    http://people.redhat.com/mgoodwin/pcp-cov/1/11check.c.html#error
    
    Fixing the problem by changing the prototypes for some of the
    __pmOptFetch*() routines that can only ever return with success
    from type int to type void.

commit e66fd418a192cb34cd6bfdecf5c583bc0a54519b
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 11:20:16 2012 +1100

    Guard against null pointer dereference in pmieconf rule resetting.

commit e2b0b32917fe6565187ddd6fad592f42b4eb76ab
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 11:17:39 2012 +1100

    Fix null pointer dereference in pmieconf rule resetting

commit ef648f813f66e0584d22fe80d70dbb9fc647399e
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 11:15:20 2012 +1100

    Remove two dead code blocks in pmieconf parser.

commit 72ab3c7b28248e47a8810dabc460560a858565a4
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 11:07:53 2012 +1100

    Fix incorrect sizeof(ptr) on error message buffer in pmieconf.

commit 6785e340ceac53ff8c5a43af53de80b2d9d5dd22
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 11:03:09 2012 +1100

    Ensure we do not free an on-stack memory reference.

commit 183e6da725bdaa0a89a1782b38672a3765a766ba
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 10:15:36 2012 +1100

    Remove accidental commit to build makefile earlier.

commit 93f32c5c27f38f72de3fcd734972358ae2552135
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 09:50:24 2012 +1100

    Fix memory and file desc leaks in pmda cache routine error paths.

commit cfff985bc4d9c3e357b86a98bf24defddd841a37
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 09:44:24 2012 +1100

    Fix too-large memory allocations in dynamic namespace helpers.

commit dee908650a63f2577dca2e646269b23df77ddd9f
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 09:36:52 2012 +1100

    Fix memory leak on decoded PMNS name.

commit 799dff13672548c19b404385003129ead4964061
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Feb 2 09:20:48 2012 +1100

    Resolve niggling pmlogsummary issues uncovered by coverity
    
    Mainly surrounding pmResult pointers on error paths, and other
    pointer error condition handling.  Also a couple of unhelpful
    null-checks-after-use resolved.

commit 9dbb058f206c2a7507f9cd7efee6e705eccc61a1
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Feb 2 07:03:38 2012 +1100

    pmcd/pmcd.c - stray_semicolon
    Original Coverity case #295
    http://people.redhat.com/mgoodwin/pcp-cov/1/295dostore.c.html#error
    
    Replace null statement (added to placate gcc!) with an assert() ...
    we _really_ do expect the dup() call to succeed!

commit 239b2a8bf8aeefa1d8af7228c9833864a794eced
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Feb 2 06:57:13 2012 +1100

    pmcd/dopdus.c - null_returns
    Original Coverity case #205
    http://people.redhat.com/mgoodwin/pcp-cov/1/205dostore.c.html#error
    
    Conditionally free(name) before returning on error branch.

commit c2ade890d40ed7ec4c6584e60cb529df4e74bb50
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Feb 2 06:49:21 2012 +1100

    pmcd/config.c - resource_leak
    Original Coverity cases #169, #170, #192, #194 and #218
    http://people.redhat.com/mgoodwin/pcp-cov/1/169dostore.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/170dostore.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/192dostore.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/194dostore.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/218dostore.c.html#error
    
    Clean up partial malloc()s on various error branches when syntax
    errors found in pmcd configuration file lines.

commit 0dfb8a11100a858e0bf610f9c63f88036db7bc50
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Jan 31 20:55:11 2012 +1100

    pmcd/dostore.c - null_returns
    Original Coverity case #127
    http://people.redhat.com/mgoodwin/pcp-cov/1/127dostore.c.html#error
    
    Add assert(), as ap is guaranteed to be non-NULL in this case thanks
    to earlier grouping by domain in SplitResult().

commit ceb12dd91a882563b4e4ec5b15cbc4254ce27dee
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 28 16:00:14 2012 +1100

    libpcp/logutil.c - use_after_free
    Original Coverity case #345
    http://people.redhat.com/mgoodwin/pcp-cov/1/345logutil.c.html#error
    
    Added another check to ensure FILE *f from _logpeek() is closed.
    This does not address the original Coverity issue, which I believe
    shows incorrect analysis.

commit accaf3fe8ef4fcd44d4f4260319c3ace14e5a561
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 28 14:34:12 2012 +1100

    libpcp/pmns.c - uninit
    Original Coverity case #298
    http://people.redhat.com/mgoodwin/pcp-cov/1/298pmns.c.html#error
    
    A timeout is also an IPC error ... when removes the Coverity issue
    about numnames not being set in rare cases.

commit 4ba8377649e2521f18616b49ec8d90069c1eed22
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 28 14:28:27 2012 +1100

    libpcp/p_pmns.c - reverse_inull
    Original Coverity case #256
    http://people.redhat.com/mgoodwin/pcp-cov/1/256p_pmns.c.html#error
    
    Remove pointless test for namelist != NULL.

commit 6b8534a141b72a384da0c410675d3c2b9a0071a3
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 28 14:23:43 2012 +1100

    libpcp/logmeta.c - resource_leak
    Original Coverity case #247
    http://people.redhat.com/mgoodwin/pcp-cov/1/247logmeta.c.html#error
    
    Added some free(dp) calls on the error branches.

commit dccd6bee204338bf6d6a2b8849926a7efb982ef9
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 28 06:34:56 2012 +1100

    libpcp/fetchlocal.c - resource_leak
    Original Coverity case #230

http://people.redhat.com/mgoodwin/pcp-cov/1/230fetchlocal.c.html#error
    
    Better cleanup of malloc'd regions on error branch.

commit 9c0dd0e21dc07e93f7b00f9d0f3b27834828792c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 28 06:26:38 2012 +1100

    libpcp/interp.c - resource_leak
    Original Coverity case #189
    http://people.redhat.com/mgoodwin/pcp-cov/1/189interp.c.html#error
    
    Other than the "numinst==0" corner case, there is no functional
    change here ... rework the guards around the free() calls in the
    hope that this will convince Coverity that there is no issue.

commit 55cbb6ce25b846aa8a4ccfbf2d492b7e6a7f1b54
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 22:24:36 2012 +1100

    libpcp/logmeta.c - resource_leak
    Original Coverity cases #181 and #204
    http://people.redhat.com/mgoodwin/pcp-cov/1/181logmeta.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/204logmeta.c.html#error
    
    Added calls to free() to release local allocations on error
    branches.

commit c978eae62d43e7ca61eab56c837c38b0febf97db
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 21:40:54 2012 +1100

    libpcp/logportmap.c - resource_leak
    Original Coverity case #164

http://people.redhat.com/mgoodwin/pcp-cov/1/164logportmap.c.html#error
    
    Add free(laddrs) on error branch.

commit 1192405b51d3c1bc793b4a100719f01a81af9d23
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 21:30:25 2012 +1100

    libpcp/connectlocal.c - resource_leak
    Original Coverity case #163

http://people.redhat.com/mgoodwin/pcp-cov/1/163connectlocal.c.html#error
    
    Add free(config) on error branch.

commit f5132da3cf24c24c9a6dded81d782aa0f0d45f90
Merge: ee5f031 b15b6ef
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 15:00:47 2012 +1100

    Merge branch 'oops' into dev

commit b15b6ef72f829a5466b169bd6486001b542f61ee
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 13:24:45 2012 +1100

    libpcp/fetch.c - resource_leak
    Original Coverity case #161
    http://people.redhat.com/mgoodwin/pcp-cov/1/161fetch.c.html#error
    
    No real problem here (newlist is not set in __dmprefetch() if newcnt
    <= numpmid on return) ... cosmetic code rearrangement to try and
stop
    Coverity complaining.

commit ee5f0319c37bab74273403f26915c7cec8b2ac31
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 12:16:10 2012 +1100

    libpcp/context.c - resource_leak
    Original Coverity case #155
    http://people.redhat.com/mgoodwin/pcp-cov/1/155context.c.html#error
    
    Call free(errmsg) on the error branch after reporting the error.

commit 15fbdcbae3dd737d54f4c532af7e4ec7cda23b54
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 07:10:13 2012 +1100

    libpcp/pmns.c - resource_leak
    Original Coverity cases #153, #156, #165, #166, #173, #178, #233,
     #234 and #242.
    http://people.redhat.com/mgoodwin/pcp-cov/1/153pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/156pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/165pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/166pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/173pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/178pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/233pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/234pmns.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/242pmns.c.html#error
    
    On several error branches, add calls to free() to release storage
    that has been allocated but that will not be used as a result of
    the error condition ... all very low probability of being seen
    and low impact.

commit 51606026be68c56b77d7f8835663e1021fad92e7
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 06:50:50 2012 +1100

    libpcp/spec.c - resource_leak
    Original Coverity case #147.
    http://people.redhat.com/mgoodwin/pcp-cov/1/147spec.c.html#error
    Conditionally call free(host) on error branch.

commit 9f601a5c6a3fa78443bba6578f2c705b61bd2894
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 06:25:32 2012 +1100

    libpcp/interp.c - null_returns
    Original Coverity cases #128, #129, #132 and #133.
    http://people.redhat.com/mgoodwin/pcp-cov/1/128interp.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/129interp.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/132interp.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/133interp.c.html#error
    
    Add assert() to ensure result from __pmHashSearch() is not NULL
    in the places where we assume this to be the case.

commit 62a0c2e085c44039de144482e2f5b141399d949f
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 27 06:20:00 2012 +1100

    libpcp/units.c - no_effect
    Original Coverity case #124.
    http://people.redhat.com/mgoodwin/pcp-cov/1/124units.c.html#error

commit d89bda21816ffaf822a329d97735f104a67b97bd
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 26 22:54:19 2012 +1100

    libpcp/logutil.c - use_after_free
    Original Coverity case #342.
    http://people.redhat.com/mgoodwin/pcp-cov/1/342logutil.c.html#error
    
    __pmlogwriteLabel() changed to not call fclose() on the error
branch ...
    failure is reported via pmprintf() in __pmlogwriteLabel() and we
tend
    to assume __pmlogwriteLabel() just works, so there is little or no
error
    handling in the caller code.

commit 6f0b83e4895eac1d7dda65b47c491bcff389837c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 26 22:39:44 2012 +1100

    libpcp/logutil.c - resource_leak
    Original Coverity case #217.
    http://people.redhat.com/mgoodwin/pcp-cov/1/217logutil.c.html#error
    
    Better capture of preconditions for pmFreeResult(rp) call on return
    path.

commit afd497d87027cb502f9a610920718d6010e365b9
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 26 22:19:38 2012 +1100

    libpcp/logutil.c - resource_leak
    Original Coverity case #174.
    http://people.redhat.com/mgoodwin/pcp-cov/1/174logutil.c.html#error
    
    Add fclose(f) on unlikely error branch.

commit 987c91de0a7a5de2d3087e0c9d7832f7e142a10c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 26 22:02:20 2012 +1100

    libpcp/util.c - negative_returns
    Original Coverity case #109.
    http://people.redhat.com/mgoodwin/pcp-cov/1/109util.c.html#error
    
    Check dup() fails case.

commit 0276fb926dc94f9173284e78d8cb38a72b8ab23c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 26 21:34:25 2012 +1100

    libpcp/derive.c - resource_leak
    Original Coverity case #235.
    http://people.redhat.com/mgoodwin/pcp-cov/1/235derive.c.html#error
    
    fclose(fp) added.

commit a3393e515b641dcbcf2556bc96e10dc71a1df1c6
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 26 21:14:28 2012 +1100

    libpcp/derive.c - resource_leak
    Original Coverity case #216.
    http://people.redhat.com/mgoodwin/pcp-cov/1/216derive.c.html#error
    
    Added assert() and explanatory comment to emphasize that P_INIT code
is
    only executed once per expression.
    
    This commit also fixes issues #221 and #229.

commit f3717b333ce05b402abd0765098d66d3f7f0a531
Merge: 52fd399 0a0df22
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 26 16:20:03 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/markgw/pcp/pcp into dev

commit 52fd399c829b656dca7b3d2d59279741deedb334
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 26 16:11:04 2012 +1100

    libpcp/derive.c - resource_leak
    Original Coverity cases #172 & #196
    http://people.redhat.com/mgoodwin/pcp-cov/1/172derive.c.html#error
    http://people.redhat.com/mgoodwin/pcp-cov/1/196derive.c.html#error
    
    Added explicit assert().
    
    Also redo the fix for Original Coverity case #307.
    http://people.redhat.com/mgoodwin/pcp-cov/1/307derive.c.html#error
    which was botched in commit
2b3964bbcb0c17b6c6f9374578c3458061644826.

commit 0a0df221de0ae11c28d57c92d338126b3a50624f
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Wed Jan 25 11:21:25 2012 +1100

    Defensive change to check the file descriptor before the read,
    rather than relying on EBADF error handling.
    
    	modified:   src/pmdas/logger/event.c

commit 7ac8602147ae21359977b3cfb03b1dd8d93e51fd
Author: Ken McDonell <kenj at internode.on.net>
Date:   Wed Jan 25 06:47:32 2012 +1100

    libpcp/derive.c - resource_leak
    Original Coverity case #212.
    http://people.redhat.com/mgoodwin/pcp-cov/1/212derive.c.html#error
    
    Add one more free_expr(expr) before return NULL.

commit 009518a5c4e80c449fa7acade054e0aa59cdeb78
Author: Ken McDonell <kenj at internode.on.net>
Date:   Wed Jan 25 06:31:29 2012 +1100

    libpcp/derive.c - unused_value
    Original Coverity case #316.
    http://people.redhat.com/mgoodwin/pcp-cov/1/316derive.c.html#error
    
    Report string context where (unexpected) parser error occurs.

commit 2b3964bbcb0c17b6c6f9374578c3458061644826
Author: Ken McDonell <kenj at internode.on.net>
Date:   Wed Jan 25 06:22:58 2012 +1100

    libpcp/derive.c - unreachable
    Original Coverity case #307.
    http://people.redhat.com/mgoodwin/pcp-cov/1/307derive.c.html#error
    
    Set eof, then return ... duh!

commit 00e76cdccdd3d3eefb4d0a64ab14f3b4f5e8e2c3
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Jan 24 14:51:56 2012 +1100

    libpcp/interp.c, libpcp/logutil.c & libpcp/pmns.c - negative ftell()
returns
    Original Coverity case #105.
    http://people.redhat.com/mgoodwin/pcp-cov/1/105interp.c.html#error
    
    This commit also reworks the changes for Coverity cases #91 and #98.
    
    In all the places where we use the results from ftell(), add an
assert
    to ensure the result is >= 0 ... the error cases should not happen
and
    are only expected by Coverity ... 8^(>

commit ece0188d94541906e5746545481ae5b082a3e560
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Jan 24 14:30:21 2012 +1100

    libpcp/pmns.c - negative_returns
    Original Coverity case #98.
    http://people.redhat.com/mgoodwin/pcp-cov/1/98pmns.c.html#error
    
    Add check for ftell() returning a negative value ... sighting
elephants
    with purple spots has a higher probability, but this should make
    coverity happy.

commit 0589401900c8733e5de48ba6945b91e23979934c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Jan 24 10:34:34 2012 +1100

    libpcp/logutil.c - negative_returns
    Original Coverity case #91.
    http://people.redhat.com/mgoodwin/pcp-cov/1/91logutil.c.html#error
    
    Add check for ftell() returning a negative value ... sighting flying
pigs
    has a higher probability, but this should make coverity happy.

commit 74ccf688dbac1fdfd928a814fbd7fe9405cc4bad
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Jan 24 10:25:44 2012 +1100

    libpcp/derive_fetch.c - forward_null
    Original Coverity case #73.

http://people.redhat.com/mgoodwin/pcp-cov/1/73derive_fetch.c.html#error
    
    No functional code change here, but added an assert() to ensure that
    np->left is not NULL before it is dereferenced.

commit 4aa8b7d89782c620118278d5335d4f07fca60263
Author: Ken McDonell <kenj at internode.on.net>
Date:   Tue Jan 24 09:45:51 2012 +1100

    libpcp/logutil.c - negative_returns
    Original Coverity cases #90 and #100.
    http://people.redhat.com/mgoodwin/pcp-cov/1/90gutil.c.html#error
    and
    http://people.redhat.com/mgoodwin/pcp-cov/1/100gutil.c.html#error
    
    Check for fd (for temp file create) being negative.

commit a4aaef968b1d382b2d8d350b6ce274487bba381c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Jan 23 20:53:39 2012 +1100

    libpcp/p_pmns.c - forward_null
    Original Coverity case #69.
    http://people.redhat.com/mgoodwin/pcp-cov/1/69p_pmns.c.html#error
    
    Better guards around the use of the optional statuslist argument.

commit 5b84262482ac8c8ffc85146f8b937d70dc9b23c0
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Jan 23 07:03:02 2012 +1100

    libpcp/p_pmns.c - forward_null
    Original Coverity case #68.
    http://people.redhat.com/mgoodwin/pcp-cov/1/68p_pmns.c.html#error
    
    Add explicit check for case that should never happen.

commit 04df4cd47beacd9a25d2a9c460433f4014c4aa8f
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Jan 23 06:52:08 2012 +1100

    libpcp/derive.c - forward_null
    Original Coverity case #67.
    http://people.redhat.com/mgoodwin/pcp-cov/1/67derive.c.html#error
    
    No functional code change here, but removed a redundant test and
added
    an assert() to ensure the pointer in question is indeed not NULL.
    
    Also moved the #include <assert.h> from derive.h to the two
derive*.c
    files to make it more obvious.

commit ee414dd26779d50e40dd58e476128cbb347dc9af
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sun Jan 22 21:07:20 2012 +1100

    libpcp/optfetch.c - forward_null
    Original Coverity case #60.
    http://people.redhat.com/mgoodwin/pcp-cov/1/60optfetch.c.html#error
    
    No functinal code change here, but added an assert() to ensure the
    pointers in question are indeed not NULL.

commit fd4347f21784f30852a17f541df5ffc4b40b1b12
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sun Jan 22 07:05:13 2012 +1100

    libpcp/p_result.c - deadcode removal
    Original Coverity case #36.
    http://people.redhat.com/mgoodwin/pcp-cov/1/36p_result.c.html#error

commit f3e61c2939b5b0c8c800c3b6dc1d7f4edab9324f
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sun Jan 22 06:51:36 2012 +1100

    libpcp/pmns.c - deadcode removal
    Original Coverity case #33.
    http://people.redhat.com/mgoodwin/pcp-cov/1/33pmns.c.html#error

commit 2d569de9e6246c396f2684995280ca511e519f25
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 21 21:42:34 2012 +1100

    libpcp/pmns.c - rework deadcode removal
    Redo error handling within recursive calls.
    Original Coverity case #30.
    http://people.redhat.com/mgoodwin/pcp-cov/1/30pmns.c.html#error

commit 470e92bbd7069b615ee057358bb8885acc1f0374
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 21 21:05:29 2012 +1100

    libpcp/profile.c - deadcode removal
    Original Coverity case #27.
    http://people.redhat.com/mgoodwin/pcp-cov/1/27profile.c.html#error

commit 05c47a167f0e0bda4016edb58a8877705b381e85
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 21 20:58:53 2012 +1100

    libpcp/profile.c - deadcode removal
    Original Coverity case #26.
    http://people.redhat.com/mgoodwin/pcp-cov/1/26profile.c.html#error

commit 61b4df96d2151dc43bbbaf4f0f7758a9bbed3d7d
Merge: 2fe65f7 538df34
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 20 22:00:06 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/markgw/pcp/pcp into dev

commit 2fe65f71d9394ebdaf90b59ed4812fdbd961c9bc
Merge: 5785e65 afc2e9c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 20 21:55:51 2012 +1100

    Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev

commit 5785e65169e617647fff735122d5e1e62a1a4e77
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 20 21:34:38 2012 +1100

    FreeBSD PMDA - newie
    
    A basic kernel PMDA for FreeBSD.  There are enough metrics here to
allow
    pmstat to run, the pmchart Overview chart works, and most of the
"sanity"
    group of QA tests pass.
    
    Other metrics could easily be added using the sysctl() or /dev/mem
    reader methods used so far.
    
    All the code here has been developed from scratch, although
the /dev/kmem
    reader parts rely on recalling fragments from user space code I
wrote
    for Edition 7 Unix some 34 years ago! ... 8^)>

commit 0f6d0c0f4879095e6951549a06e5408019183544
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Jan 20 21:20:26 2012 +1100

    chkhelp - rework -e option
    
    On reflection, existence checking only makes sense if you use the
PMNS,
    not the helpfile, to enumerate the metrics to be checked.

commit 538df34b5cf9e3ef927ac91056c3046aa9e2ec88
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Tue Jan 17 10:48:22 2012 +1100

    Fixed ptr references to an out of scope variable.
    
    	modified:   src/pmdas/trace/src/trace.c

commit 5bad75a77ccdc1ade91f450100ef90cff8c1d110
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Tue Jan 17 10:41:46 2012 +1100

    delete unused variable.
    
    	modified:   src/pmdas/linux/proc_pid.c

commit e8ab89bfe839a30eb38f0ff2713f52c976bf096a
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Tue Jan 17 08:44:02 2012 +1100

    Fix typo causing build error.
    
    	modified:   src/pmdas/cisco/probe.c

commit 60160b0256b119e80226a8fb8db1a42f7d462794
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 17:56:18 2012 +1100

    fclose file pointer in err handling path to avoid mem leak
    
    	modified:   src/pmdas/linux/ksym.c

commit f9db46f0edc667414e838c54cf3daf2061b92576
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 17:50:14 2012 +1100

    correctly close file pointer in err handling paths to plug memory
leak
    
    	modified:   src/pmdas/linux/proc_slabinfo.c

commit 37f3e00f225985c54d954d2d1331e86652c360bc
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 17:41:55 2012 +1100

    fclose the file pointer in do_sendmail_cf(0 to avoid memory leak.
    
    	modified:   src/pmdas/sendmail/sendmail.c

commit d4ea1c98fbeb39e9fa8849a619b014671cc6dabb
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 17:28:06 2012 +1100

    fclose fspec in err handling paths to avoid memory leak
    
    	modified:   src/pmdas/sample/src/sample.c

commit 95f3c1849f7fe8e1fc41b4413997bd9e4977d9e3
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 16:46:23 2012 +1100

    fclose the iosucker stream befoe returning - plugs a memory leak.
    
    	modified:   src/pmdas/trace/app2.c
    	modified:   src/pmdas/trace/app3.c

commit 3171338c339f59c1bb724ee234c3a74555738b81
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 16:40:16 2012 +1100

    fclose file in error handling path to plug a leak
    
    	modified:   src/pmdas/linux/proc_net_tcp.c

commit 3160e454f088c848a4e7f7bbfe4a0c1e61343500
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 16:36:56 2012 +1100

    pmdaCacheStore() .. store() .. insert_cache() makes it's own strdup
of name
    so passing a strdup'd name to pmdaCacheStore and not freeing it is a
leak.
    
    	modified:   src/pmdas/linux/cgroups.c

commit 6c2709aff6abf2d4856f8d9c74bc6e7a1819cd73
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 15:41:40 2012 +1100

    Fix minor memory leak in error handling path.
    
    	modified:   src/pmdas/trace/src/pmda.c

commit e9f2255c3b28dad71929e1ecbb076b6822fd661e
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 15:35:25 2012 +1100

    Fix memory leak in error handling path.
    
    	modified:   src/pmdas/linux/cgroups.c

commit e55684b74c814268427946d9bff4e8e850b526e5
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 15:18:01 2012 +1100

    Only close(fd) if it's valid.
    
    	modified:   src/pmdas/linux/proc_pid.c

commit dad59809887c88f99b473e6826b27cdb7983b01c
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 14:23:25 2012 +1100

    Fix inverted logic for closing the log fd.
    
    	modified:   src/pmdas/logger/event.c

commit bc675af185bfcf684105702d21222121e93aec6e
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 14:19:01 2012 +1100

    check return of dup() before passing to fdopen()
    
    	modified:   src/pmdas/cisco/telnet.c

commit 141e27547f3e66ff73120f6d89d1639a4d5adc49
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 14:15:18 2012 +1100

    Check return of dup() before passing to fdopen().
    
    	modified:   src/pmdas/cisco/probe.c

commit 1fce615be97a0da2654a7a9d6eea4e9dc81260a1
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Mon Jan 16 14:08:30 2012 +1100

    Fixed a poorly defined macro in weblog.h and incorrect formatting in
weblog.c
    
    	modified:   src/pmdas/weblog/weblog.c
    	modified:   src/pmdas/weblog/weblog.h

commit afc2e9ca24a6d24484d915659760cfb9df7b9d67
Author: Nathan Scott <nathans at debian.org>
Date:   Mon Jan 16 10:37:24 2012 +1100

    Add Kens review comment (fixes) to process/mount PMDA fd leaks.

commit f0267272b92abedf65a9d0fd3fd35ef7a6d45840
Author: Nathan Scott <nathans at debian.org>
Date:   Sun Jan 15 17:27:53 2012 +1100

    Win32 build fix updates for pmdaetw on other platforms.

commit 84b4ecd8691f2775a21e0dafed97eb80b214dea4
Author: Nathan Scott <nathans at debian.org>
Date:   Sun Jan 15 17:06:26 2012 +1100

    Win32 build fixes from awhile back.

commit 1cac8cf58988c5609860275b2669adebd972a360
Author: Nathan Scott <nathans at debian.org>
Date:   Sun Jan 15 16:28:31 2012 +1100

    Further exploratory work on pmdaetw.

commit a623c25fcaeae9905f832077ce81ae951c2e7c3a
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 14 17:22:03 2012 +1100

    Build and PMDA domain number changes for FreeBSD

commit 8260fc3a7af329f1a225b56c18280486d81b6727
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Jan 14 17:20:17 2012 +1100

    chkhelp - add -e option to check if help text exists

commit c6581fce42234935421440ba189a55e33f076ac4
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Sat Jan 14 10:36:34 2012 +1100

    Add missing break (benign).
    
    	modified:   src/pmdas/sample/src/sample.c

commit 7875064dc72e676ec6fab8aa3a0ce9868133169a
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Sat Jan 14 09:47:30 2012 +1100

    Make sure the partition instance was found earlier.
    
    	modified:   src/pmdas/linux/proc_partitions.c

commit 77abd89520af7386535a1f13e2e0b28a168b9b5b
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Sat Jan 14 09:30:04 2012 +1100

    Check datap buffer isn't NULL before reading into it.
    
    	modified:   src/pmdas/lustrecomm/refresh_file.c

commit 6c60b8c277af0249b5bc9e3eede28fef1666b416
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Sat Jan 14 09:27:11 2012 +1100

    Check return value for fstat.
    
    	modified:   src/pmdas/logger/event.c
    	modified:   src/pmdas/mmv/mmvdump.c

commit d8f0d28e4bfa4505d92ed5307ed4632205e3a6b7
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Jan 13 11:00:30 2012 +1100

    Fix check for older kernel versions, logic for eaqrly 2.6 was just
plain wrong

commit 6ca653424dd265dd094f356b02d382bcf0a822fd
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Jan 13 09:27:59 2012 +1100

    Fix invalid free attempt on result in log control pdu error path.

commit d1552a02e6828d5a5248b01343f33f1d6936b5dd
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Jan 13 09:26:36 2012 +1100

    Fix total botch of logic in pmLoopRegisterSignal, clearly noones
ever used this.

commit 4aa0bb68365670ccf3bf35211b9d6dbbe504f550
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Jan 13 08:47:07 2012 +1100

    Resolve some dodgey use of file pointers in the mounts PMDA.

commit 64fa9ceb3bee1fb44578f2ee5c583b8839228ff5
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Jan 13 08:45:48 2012 +1100

    Improve handling of fopen return value in linux PMDA interrupts
code.

commit a57c46a7b483fbd5ea43234fa8e13226d2e08841
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Jan 13 08:41:43 2012 +1100

    Resolve some dodgey use of file pointers in the process PMDA.

commit e57f80da1619431343b596611cae38d599832cd1
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Jan 13 08:28:05 2012 +1100

    Ensure cpu indom pointer is set now that struct properly zeroed.
    
    Resolving an earlier issue of not-zeroing the linux PMDA proc_stat
    structure has exposed a working-by-chance side-effect ... an indom
    pointer is now zeroed when before it was allowed to remain set even
    though the structure was supposed to be zeroed.  Ugh.

commit 4ca7322b29388290a08fa9291e2837c8015f800f
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Jan 13 08:15:14 2012 +1100

    Ensure null not passed to strcmp in PCP::PMDA pmns_write.

commit 1d0008ddea554e83dc588f9318de1e1016146958
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Jan 12 08:42:22 2012 +1100

    Resolve a benign access to uninitd memory in pmdalinux scsi code.

commit 67064c5a97d44ea8aa8207dc58251d3ca353e367
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Jan 12 08:40:32 2012 +1100

    Fix several dbpmda issues found by static analysis.
    
    Resolve an off-by-one error on memory allocation for stings,
    a leaked result pointer, several missing negations on errno
    return codes, and an uninitialised use of sts variable in an
    error path.

commit 700a6a0187de8629c2ddb3617145a9261ae7eb25
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Jan 12 08:29:01 2012 +1100

    Fix libpcp_http issues found by static analysis.
    
    Resolve off-by-one errors on memory allocation for stings.

commit 7d65a1099198614183f41c8d81b299840c66fdc5
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Jan 12 08:26:44 2012 +1100

    Fix pmlogreduce issues found by static analysis.
    
    Couple of cases of using equality test instead of assignment
    for function call return, and a null-pointer dereference in
    some error handling code.

commit 5550f722f8912e2235e1c396f3a936b237cd1915
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Jan 12 08:15:21 2012 +1100

    Fix several incorrect pmdalinux memset-to-zero sizes initialisation
code.

commit 3950c261a4d330f0be0ad12faa1e72369fc0f5fd
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Jan 11 15:12:36 2012 +1100

    Handle missing config files and missing or unreachable hosts more
gracefully

commit 4f56d91825447cb2afdf42ea6014e76e171fd362
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Jan 10 17:05:22 2012 +1100

    Phase 2: Schema change.  support multiple hosts with the correct new
naming
    system

commit 0793714e43e293482f29b842e22ecd403500f3d6
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Jan 10 16:05:04 2012 +1100

    Phase 1 of schema change.  This should include all the pmid changes.
    For simpler testing purposes, this only includes support for one
snmp host

commit f058da3869fd039e8a070d46cf59a814cde8d1b5
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Jan 10 12:02:27 2012 +1100

    Load the max row oid from the config file

commit e4dbcf1b27a46725ece75e58a7b85e0a763ecc2e
Author: Hamish Coleman <hamish at zot.org>
Date:   Sat Jan 7 23:12:28 2012 +1100

    Add Makefile and link snmp pmda to build process

commit de4398d2c9af604f14ae969e198a7aa4abbe6758
Author: Hamish Coleman <hamish at zot.org>
Date:   Sat Jan 7 22:38:22 2012 +1100

    Fixup copyright dates

commit 87ff932dcf8089b2d3e1e3e92520afbb8a71ce69
Author: Hamish Coleman <hamish at zot.org>
Date:   Sat Jan 7 22:34:38 2012 +1100

    Clarify some comments and return code reasons

commit e19a60ebf5d51dbd8d13ac0c9a3ca725565848b3
Author: Hamish Coleman <hamish at zot.org>
Date:   Sat Jan 7 19:28:54 2012 +1100

    minor POD updates

commit adbd93fb94c475d93c9d3b44350b2d2c8d0ab13a
Author: Hamish Coleman <hamish at zot.org>
Date:   Sat Jan 7 18:07:00 2012 +1100

    Move documentation TODO into the POD text

commit 6ac821f7b71445741c3a20c716bd206741249ef4
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 5 22:10:40 2012 +1100

    Assorted - botch in metric name lookup error handling
    
    When pmNameLookup() is called with a list of metric names that
    include a mix of derived metrics, dynamic metrics and unknown
    metrics, the logic for handling the mixture of "odd" pmids
    (PM_ID_NULL and pmid_domain(pmid) == DYNAMIC_PMID in particular)
    was not always correct.
    
    Found problems first in pmcd by accident during BSD pmda
development,
    then similar problems identified in dbpmda and libpcp.
    
    QA/509 now checks for this type of botch.

commit 501a0ecee32dfda143c3e323c6f00faf5211fd49
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 5 10:45:35 2012 +1100

    linux pmda - correct typo in comment

commit 35f4195570590e924a6e8b41d8fe6d4fecbd96c2
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 5 09:13:28 2012 +1100

    configure.in - BSD changes
    
    Need group "wheel" not "root" for install ... just like darwin ...
8^)>

commit a87f754cf45f45167b52537fcb5566331c1a0b2c
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Jan 5 09:08:25 2012 +1100

    domain numbering - FREEBSD -> BSDKERNEL
    
    Hoping that the one kernel PMDA will work for all the BSD variants,
    so rename the domain name to be more generic.

commit cc04a50cc179cf71e86dc44e3ce50efb80eee980
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Dec 30 06:22:09 2011 +1100

    Cleanup compressed man pages
    
    Another place where all of .gz, .bz2, .lzma and .xz need to be
mentioned.

commit 654faad885b48e72a650aeca2bcb3a1e43bf4dbb
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Dec 30 06:20:34 2011 +1100

    Include /var/lib/pcp/config/pmlogconf in package
    
    This directory did not have an explicit "install" line, and was
    missing from the packaging.
    
    Found in dredging through the Mandriva rpm installation log.

commit f5c7662294b6d95bfe8e3231a242af5ce9e319e0
Author: Ken McDonell <kenj at internode.on.net>
Date:   Wed Dec 28 18:08:08 2011 +1100

    More Mandriva man page hell
    
    In 2011.0, the Mandriva pixies moved from .lzma compression for man
    pages to .xz compression.  This changes the names of all the man
page
    files in the packages and the "dirt" in the build area ... wholesale
    changes to configure.in and builddefs.in to accommodate the
packaging
    changes, then lots of .gitignore changes.

commit 97b470fd5191add50f876e573240ee427c4ece72
Author: Ken McDonell <kenj at internode.on.net>
Date:   Wed Dec 28 17:10:29 2011 +1100

    pcp.spec.in - fileutils -> coreutils
    
    At least on Mandriva 2011.0 there is no fileutils rpm, and the
things
    we depened on from fileutils (chgrp, chown, cp, ls, ...) all appear
to
    in coreutils, so change the Requires clause.
    
    If this is not right for all the RPM platforms, then those that know
    more than I will have to add vendor-specific variations.

commit 878062a4532dd31328f7f3595bf99202b2407ba1
Author: Ken McDonell <kenj at internode.on.net>
Date:   Wed Dec 28 10:25:33 2011 +1100

    Drive a stake into the heart of the symlinked <pcp> in the build
    
    We don't need
        ln -s $(TOPDIR)/src/include pcp
    throughout the build.
    
    There was a previous attempt to clean this up, but some of the PMDAs
    were apparently spared ... no such mercy this time!

commit c8b4dd6c8c68225b6fd2dd47a4ea65166702d6a4
Author: Ken McDonell <kenj at internode.on.net>
Date:   Wed Dec 28 06:50:02 2011 +1100

    Changes for Mandriva build
    
    First ensure configure sets target_distro=mandriva and then a bunch
    of changes that are fallout from Mandriva using .lzma compress man
    pages that is something of a train wreck in our build that assumed
    .gz compressed man pages in lots of subtle ways.

commit 6b2ea41d404d4a8b36a5d9ba889bcd5fc9382534
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 26 19:06:59 2011 +1100

    trace demo - more tweaking of makefile for stub library

commit f3a667b400bfd0dbf577c0ed1b3e051816115622
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 26 10:30:49 2011 +1100

    pmlogrewrite - missing newline in verbose diagnostic output

commit 841151b211584a731fcbfb19623ba4666262eb11
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 26 07:04:42 2011 +1100

    libpcp_trace stub library - Mac OS X rework
    
    Handling of DSO_VERSION and DSO_SUFFIX was not correct.  Generalized
    to handle ELF style
      /usr/lib/libpcp_trace.a  /usr/lib/libpcp_trace.so  /usr/lib/libpcp_trace.so.2
    and Mac OS X style
      /usr/lib/libpcp_trace.2.dylib

commit 3f0e5f1133e79e29c12c145dcee3dba9c0d9c6de
Merge: 4b3830e 2d127ae
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Dec 23 12:29:34 2011 +1100

    Merge git://oss.sgi.com/pcp/pcp into dev

commit 2d127ae4e59601df3a99cd134e11ef229c094ae8
Merge: a78a73f cfa0e02
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Dec 23 06:51:29 2011 +1100

    Merge branch 'dev' of git://oss.sgi.com/kenj/pcp into dev

commit a78a73f8e945306b0c1bbd7dd6ea1dc00d25bfd1
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Dec 23 06:45:30 2011 +1100

    The Windows build will be driven from a separate repo now.
    
    Remove the soon-to-be-dropped Strawberry-based build for
    Windows, in favour of a separate pcp-glider git repo which
    will house an installer based on mingw-get[-inst].

commit 43bdad1a6a9dc11e9e668029b134cfdbf3f2700b
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Dec 23 06:42:38 2011 +1100

    Fix failure in QA test 498 with multiple queues.
    
    When multiple queues in use, if realloc moved the memory
    the base queue lives at then any backreferences via TAILQ
    pointers become invalid.  Fixed by re-initialising queues
    when needed such that this can no longer happen.

commit 3d58c51bf5713d580232921f117a55074101bd80
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Dec 23 06:40:14 2011 +1100

    Use INT_MAX in ipc.c like everywhere else, no macro needed.

commit 4b3830e00a64d4649ecc3dc2467a61bbd2a0df1e
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Dec 22 08:36:02 2011 +1100

    libpcp/connectlocal.c - fix buffer overrun error
    
    Logic error in __pmSpecLocalPMDA() in the case of a malformed
    specification ... QA 344 was exposing this, but only on some
platforms.

commit 1918b64bf3292532722b83c081e64dd51e37888d
Author: Ken McDonell <kenj at internode.on.net>
Date:   Thu Dec 22 07:27:02 2011 +1100

    libpcp_gui/record.c - fix string not-terminated bug
    
    In building rp->public->logfile, the optional addition of the
filename
    separator did not leave the result null-byte terminated, making the
    following strcat() a loaded gun.
    
    Found on openSUSE 12.1, although this has little to due with SUSE
and
    more to do with the state of the stack, the glibc version in place
and
    the alignment of the planets (signficantly, this bug was found and
fixed
    on the day of the Summer Solstice in the southern hemisphere).

commit cfa0e02f46e11d5f241fa48124225a75f0c55dca
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 19 19:49:31 2011 +1100

    pmlogreduce - assorted changes
    
    Fix instance domain handling so the indom is _really_ added into the
    output archive, even in the presence of mark records and dynamic
instance
    domains.
    
    Correct a logic error in doindom() where rp->vset[i]->pmid may not
be
    the same as pmidlist[i] as a result of metrics being removed from
the
    pmResult in rewrite() ... again a problem most likely to be seen
with
    mark records and dynamic instance domains.
    
    Replace compile time #ifdef DESPERATE by run-time tests using APPL?
    debug flags.  Add comment to record scope of diags covered by each
    APPL? debug flag.

commit 294a36f2017806c40b261a16b966207372c5aeb3
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 19 19:40:06 2011 +1100

    pmval - improved diagnostic
    
    When/if pmGetInDom() fails, report the failing indom.

commit 0947bb887ae43e71f419a3c7d5765f5b911063a0
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 19 17:19:18 2011 +1100

    libpcp/interp.c - small but significant correction
    
    Two changes.
    
    1. a typo meant we were checking the wrong variable in the scan
backwards
       case (!)
    2. sign reversal in a time comparison for both forwards and
backwards
       scanning (!)
    
    Both were specific to interpolating values adjacent to a mark
record,
    where we sometimes reported "No values available", when in fact a
    value was available.  By the next fetch (away from the mark record),
    the problem was likely to have gone away.
    
    No existing QA test found this, but the new QA 508 (exercising
pmlogreduce
    in the wake of a recent problem there) exposed these corner-cases.

commit 20f8392fe6a5f29da713d4dcf6a11ff276f0b91b
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 19 16:50:23 2011 +1100

    libpcp/interp.c - improve diagnostics
    
    Consistently report times to usec accuracy (was mix of usec and
msec).
    
    Do a better job of decoding valfmt and type before duping values in
    diagnostics.

commit 4a78f580a0fd21b446add95360d1a2549647aae5
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 19 07:03:08 2011 +1100

    libpcp/logutil.c - small addition to diagnostic info

commit 83b0635387191d9a7be080dd591ebec623bb2566
Merge: 3534fbb 144a3e2
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Dec 16 06:55:17 2011 +1100

    Merge git://oss.sgi.com/pcp/pcp into dev

commit 3534fbb41da84ee94ee1ebc63f67fc4cae64b974
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Dec 16 06:47:46 2011 +1100

    libpcp - PDU buffer asserts
    
    As a defence mechanism against the sort of problems found in the
    previous interp.c fix, asserts have been added to __pmPinPDUBuf()
and
    __pmUnpinPDUBuf() to ensure their arguments are at least word (int)
    aligned as they should always be for valid use.
    
    This and the previous commit passes QA on LinuxMint 12 with no
failures.

commit e1f007d6d0d789f84385510b34afc366e9912970
Author: Ken McDonell <kenj at internode.on.net>
Date:   Fri Dec 16 06:37:26 2011 +1100

    libpcp/interp.c - rogue PDU buffer unpinning fix
    
    Customer-reported from SGI by Arthur Kepner
    original report here
        http://oss.sgi.com/archives/pcp/2011-05/msg00054.html
    follow up here
        http://oss.sgi.com/archives/pcp/2011-12/msg00006.html
    
    Problem eventually tracked down to a day-one oversight in libpcp,
and
    involves an obscure corner case in interp.c involving "mark" records
in
    the archive and 32-bit metric values ... bogus "addresses" were
being
    used as arguments for PDU buffer unpinning, and if one of these
happend
    to fall within the address range of a valid PDU buffer that was not
free,
    and the PDU buffer was re-used, then and it _might_ cause heap
corruption
    as seen in pmlogreduce.
    
    Fix has been confirmed by Arthur with reproducible test case.

commit 144a3e2a2a15e36976a99690c8ace95690206b2a
Author: Mark Goodwin <mgoodwin at redhat.com>
Date:   Thu Dec 15 23:06:29 2011 +1100

    ppc64 needs the same libdir=/usr/lib64 fixup that we already have
for x86_64.
    
    Signed-off-by: Mark Goodwin <mgoodwin at redhat.com>

commit ac24e39c93f48391062750cec46fc9b8ca27c3c8
Author: Ken McDonell <kenj at internode.on.net>
Date:   Mon Dec 12 07:14:26 2011 +1100

    thread-safe pmErrStr & build libpcp with check-statics
    
    In addition to creating pmErrStr_r(), and using this throughout
    libpcp in lieu of pmErrStr(), this commit also introduces
thread-safe
    versons of the osstrerror_r() and netstrerror_r() macros to use and
    hide the inconsistent GNU implementation of strerror_r().
    
    Also included is the check-statics script as part of the build
    to ensure additional static data items are not introduced without
    appropriate thread-safe verification.

commit 6570c717899b6e1c3cdb3f4ba068382addc8430d
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Dec 10 06:18:26 2011 +1100

    libpcp - check-statics integrated into the build
    
    libpcp is now (asserted to be) thread-safe.  All use of global data
    statics has been removed or made thread-safe ... the script
check-statics
    looks for global data statics and compares them against a list of
known
    exceptions and annotations.
    
    Introducing (or indeed removing) global data statics without
updating the
    exceptions and anotations in check-statics will cause the build to
fail.

commit f3de6b5c960a6b4a412961b820cf5ef5f1f5dc83
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Dec 10 06:12:03 2011 +1100

    libpcp/derive.c - make errmsg and pmDerivedErrStr() thread safe
    
    Made errmsg thread private.

commit 81f19557f9faf3f052698d6d31364e44374e48c5
Author: Ken McDonell <kenj at internode.on.net>
Date:   Sat Dec 10 05:57:26 2011 +1100

    libpcp - global diagnostic counters are not updated atomically
    
    We've decided to _not_ use atomic updates for the diagnostic
counters
    as an acceptable trade-off between efficiency and accuracy ... the
    counters tend to be updated frequently, but not used very much
outside
    QA.
    
    This commit adds comment annotation to document this decision in the
    relevant source files.

commit a2f36b3cf1aa4011414aff9022ee9c88260a469f
Merge: e2dbcdc f207951
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Dec 1 20:50:09 2011 +1100

    Merge branch 'dev'

commit e2dbcdc32ef319d3f3074075933c0832e3b2668f
Merge: 937e6ea 6181089
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Nov 18 06:53:15 2011 +1100

    Merge branch 'dev' of git://oss.sgi.com/kenj/pcp

commit 937e6ea7a3e2ecb7e03003f71487dabc72cf9e17
Author: Nathan Scott <nathans at debian.org>
Date:   Thu Nov 17 17:07:11 2011 +1100

    Fix error in pmdaelasticsearch instance ID lookup.

commit 8c3a5b0271166908a95cb9977548701831a9818f
Author: Nathan Scott <nathans at debian.org>
Date:   Tue Nov 15 16:53:56 2011 +1100

    Trivial cleanup tweak in pmdaelasticsearch.

commit b5041975d99d893ffe18901e21b750bf390d0418
Merge: 89fc6df b8cf6be
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Nov 4 11:18:29 2011 +1100

    Merge branch 'dev'

commit 7db2c8d1a45ae059843f4b43626828e242b75436
Author: Hamish Coleman <hamish at zot.org>
Date:   Fri Sep 16 13:26:35 2011 +1000

    Remove references to the bonding pmda from the snmp pmda

commit 70ebe01574b8d7896d2884d17151c1548f748a66
Author: Hamish Coleman <hamish at zot.org>
Date:   Fri Sep 16 13:14:29 2011 +1000

    Minor README fixes

commit d6372cd3ae595bc4030d64c4424c963e9a931bd9
Author: Hamish Coleman <hamish at zot.org>
Date:   Fri Sep 16 13:13:08 2011 +1000

    English text fixups

commit f9d757db91c62e352958eac2e21616057ccc2b1d
Author: Hamish Coleman <hamish at zot.org>
Date:   Fri Sep 16 13:12:28 2011 +1000

    Consistantly capitalise acronyms

commit 89fc6dffc9feb771b299e5a06b73943fcde7c5d0
Merge: b719ce7 8827bb8
Author: Nathan Scott <nathans at debian.org>
Date:   Fri Sep 2 14:00:56 2011 +1000

    Merge git://oss.sgi.com/pcp/pcp

commit b6e28c46339c94030549d9941d1fb89b802e8bdf
Merge: e9e72fd 2ecb876
Author: Hamish Coleman <hamish at zot.org>
Date:   Fri Sep 2 12:11:05 2011 +1000

    Merge ../snmp2pcp

commit 2ecb8767bb3517fa82bc5018553e96682d3bf43f
Author: Hamish Coleman <hamish at zot.org>
Date:   Fri Aug 12 09:43:32 2011 +1000

    Tweak readme files to be more accurate

commit 79f5281fc93ae93d109c213ad2a1de91a5868e20
Author: Hamish Coleman <hamish at zot.org>
Date:   Fri Aug 12 09:40:31 2011 +1000

    Ignore PDF version of presentation

commit f0a6570fe78307c7f30f4ae7946ccc0bb7f69919
Author: Hamish Coleman <hamish at zot.org>
Date:   Fri Aug 12 09:13:32 2011 +1000

    Add Hackathon presentation

commit bd159cb59f1b57c7f024b50d9f8b35009d6a198b
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 17:44:26 2011 +1000

    Update config file to use new columnar formats

commit 58e767514fad9ad54cd1e471134e526d892187e3
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 16:26:48 2011 +1000

    Add debugging output for decoded row and host numbers

commit fc0e734d8e2d90ccc5fa4cca3bc279779ec686c9
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 16:26:19 2011 +1000

    logging functions do not need to have a newline appended, this just
leaves blank lines in the logs

commit b4aec877b6edeec1b842ef436edc728182c24baf
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 16:25:36 2011 +1000

    BUG: instance calculation for table rows was borken

commit 63092b14ea5284f149a2a2bfd7f9a903bc8f8044
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 16:24:30 2011 +1000

    BUG: SNMP counters are unsigned

commit b8d86ce4e9751763761b1b6bdf39dae5831a7c35
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 11:26:36 2011 +1000

    Mappings defined as a simple column now show up as mulitple
instances

commit f2106379dfd8758e81733bbbaf4ab4c56227acea
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 11:15:16 2011 +1000

    BUG: initialise vars for when no config file exists

commit c3a5f52b36df4c8f7e922ffbf6b8ef880c401c1d
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 11:05:37 2011 +1000

    Create an indom to contain automatic rows for simple snmp table-like
objects

commit cc27f09aef561b79dc16638dd0ea2e64fc4eeeac
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 11:00:08 2011 +1000

    Track the number of loaded items, this will be used to create the
hostrows indom id numbers

commit 685ddefa545ce83b66ffacbf5f3dc842a81925ba
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:59:21 2011 +1000

    Add the numeric hostid to the hosts hash

commit 62aab275a27d04c578b980c42f4c14e712690b8c
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:58:24 2011 +1000

    Use symbolic names for indom numbers

commit 294612a0ccd16cc9c08b07dbfdc925a7df78ceff
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:42:20 2011 +1000

    Infer the PCP semantics from the SNMP type

commit a8ea3e985a03c520e5cc2fd9c4319e2a086f2fc8
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:14:01 2011 +1000

    Cleanup the default config and add some more examples

commit 387eccf6365a064ae1b530148e3f3c91fe1ee9c0
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:13:48 2011 +1000

    BUG: should not load the same config file twice - since the PMDA
runs with its CWD set to the same place as the default location for
config files, we cannot load the config file from the current dir

commit 5955fa9872fc7f514fc25ce5c1348e55fadb2130
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:12:28 2011 +1000

    Warn if there has been a SNMP to PCP type mismatch

commit 51162e93f356b6164da3a92be56443bbb3610308
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:11:29 2011 +1000

    Add an autoincrement mapping id character

commit 6545831a23693db3cd9b66ca91e3d80e6e628bc8
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:10:43 2011 +1000

    BUG: fix multidigit ID numbers

commit 0abae363f79981cf79fb61c38d0cc7f78dc37900
Author: Hamish Coleman <hamish at zot.org>
Date:   Wed Aug 10 10:09:45 2011 +1000

    Add usable shortcut for SNMP type name

commit d0adec724d603dfc889978d2eaf57ffbe692af86
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 21:53:09 2011 +1000

    Document callbacks, in search of a PMNS relevant one

commit f64d9eb4b0de542fc56ea75bd3a52855a3480fbb
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 20:58:12 2011 +1000

    Add snmp metric types and matching pcp types

commit d94408e16bbf9d87da5869eeca8ed6ac6c85d214
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 19:44:25 2011 +1000

    Fixup constants with better error numbers

commit bcd353809d8444e1469757bcdf9aa5c3fcda8464
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 19:17:01 2011 +1000

    Change to U32 to make pmchart demonstratable

commit 5ab012d8ffa0cbfd5ad8bc67a3c65caf895d12fb
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 18:44:55 2011 +1000

    Static mapped queries now work

commit b919ba50f90f0c32533d39859ce65b03a55dc107
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 17:54:49 2011 +1000

    Remove dead code

commit 472c2ca83197c91673882a861b172318d0d51a77
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 17:16:09 2011 +1000

    Dynamically create the domain instance list from the loaded snmp
hosts

commit e7e326d239896f9779676b4a9321b91ad7416ad8
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 16:51:05 2011 +1000

    Load hosts from config and setup a SNMP session

commit 0bb1dd273c95d12f872ff47a8ea5af015b6324c1
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 16:06:48 2011 +1000

    show debug details of internal config to the log

commit d3cd9435e83be120a11aed5b32794af8fde1383f
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 16:04:56 2011 +1000

    Add config file loading

commit 93cd2ed570b8a422ec463dab12b82edf1749d641
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 15:27:35 2011 +1000

    Now generating fake static data

commit 84292cac5d494713a83d698f67935acef19ba6d0
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 15:26:53 2011 +1000

    Ignore generated files

commit 404dc3c3386a7dfafa6437720db54476207eed10
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 15:20:58 2011 +1000

    Correct the pmid number bitfield information

commit d4c3594510bc750adf9e589fbf6b25d36dce870b
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 14:47:47 2011 +1000

    Gut the pmdasnmp module and try to send simple static values -
currently failing

commit a4ba226d27e5d8e2fe68a2b3cce09f846d50a31c
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 12:52:31 2011 +1000

    Fix the install and remove scripts for this module

commit a29fdc2218f427e951ce7a0d2aef6092f49c9360
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 12:45:14 2011 +1000

    Import pcp/src/pmdas/bonding/{Install,Remove} from PCP source

commit 770b14273e24ebfa597fcba8c24e782d8402ee34
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 12:29:47 2011 +1000

    Import pcp/src/pmdas/bonding/pmdabonding.pl from PCP source

commit 16c92ec05a2d2908729e99ac3abd0148e3a01992
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 12:12:17 2011 +1000

    Add perl dependancies to documentation

commit 9d7417897631aee7091e0aced05a9ea75bc5fd0c
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 11:53:13 2011 +1000

    Add some more targets for configurable items

commit 362f411f4fa15e1075fadede938c81654d7f6d40
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 11:52:26 2011 +1000

    Add first guess at a sample config file

commit b638c62e5e98230ec7e1272e26177d83659a84f9
Author: Hamish Coleman <hamish at zot.org>
Date:   Tue Aug 9 11:38:25 2011 +1000

    Add initial documentation

commit b719ce76ec864e2952899ea828f44cc709f8d7f6
Author: Nathan Scott <nathans at debian.org>
Date:   Mon Aug 29 11:15:24 2011 +1000

    Further work towards decoding Windows event traces.
    
    tdhconsume now mainly seems to have permissions errors for
    some traces, which might be more the way I'm running it than
    a coding issue.

commit c4971d69e3c4dcb584d10253e8744d2a18c43652
Author: Nathan Scott <nathans at debian.org>
Date:   Mon Aug 29 11:06:11 2011 +1000

    Ensure all pmdarsyslog variables initialised, else perl warns.





More information about the pcp mailing list