[pcp] coding issues and defects uncovered by Coverity scans
nathans at debian.org
Wed Feb 8 00:56:24 CST 2012
On 2 February 2012 07:11, Ken McDonell <kenj at internode.on.net> wrote:
> On Thu, 2012-01-12 at 16:14 +1100, Mark Goodwin wrote:
>> Coverity is a sophisticated static code analysis tool.
> I have another Coverity related question ... what is one expected to do
> with issues like this one?
> 40 FORWARD_NULL /src2/git/pcp/src/pmlogger/<stdout> yy_get_next_buffer
> I assume this is found in the bison output file, but there is no context
> or line number to help isolate the "issue".
Look like its generated code from lex. (from the build, flex -t lex.l > lex.c
and nm shows lex.o contains yy_get_next_buffer)
Not much we can do here I think, its in code generated by lex.
Other interesting Coverity questions though - how to get the solaris,
darwin, and windows PMDAs checked? (Coverity website says that these
are supported platforms, so would be good to do if we can).
Once we've finished the initial run-through I'll talk to Eric once
more, see if we can get a new run done and results circulated, plus
bring up these other questions.
Other trees we should start thinking about are pcp4 and pcp-gui too
btw, but might wait for the scars to start to heal before taking on
More information about the pcp