[pcp] Regression for handling of ipc_prot=notready
kenj at internode.on.net
Fri Nov 6 14:53:38 CST 2009
I'm not sure when this bit of "notready" fluff got added to pmcd's
config file (the pmcd<->PMDA protocol support has been there for a long
time, since the first Oracle PMDA was written).
However from reading the code, it looks like for a PMDA connected via a
pipe, the supported protocols in the pmcd config file are "binary" or
So the Install file should set ipc_prot to "binary notready" (I think
the comment is a little misleading, that's all).
On Fri, 2009-11-06 at 10:46 -0600, Martin Hicks wrote:
> I got a bug report today about a regression in pcp-2.9.2 and later that
> was introduced by commit 65ef4b08
> Despite removing the text ipc protocol, we still have facilities for
> ipc_prot=notready, as documented in pmcd(1). It looks like the fix is
> a small revert, although I've also added a comment:
> diff --git a/src/pmcd/pmdaproc.sh b/src/pmcd/pmdaproc.sh
> index ddfcfae..883b79d 100644
> --- a/src/pmcd/pmdaproc.sh
> +++ b/src/pmcd/pmdaproc.sh
> @@ -718,7 +718,9 @@ __choose_ipc()
> if [ $ipc_type = pipe ]
> - type="pipe binary $_dir/$pmda_name"
> + # This defaults to binary unless the Install file
> + # specifies ipc_prot=notready -- See pmcd(1)
> + type="pipe $ipc_prot $_dir/$pmda_name"
> while true
> pcp mailing list
> pcp at oss.sgi.com
More information about the pcp