[pcp] pmnewlog quirk
nscott at aconex.com
Sun Mar 1 20:43:20 CST 2009
I came across a slight oddity in pmnewlog - it has code like this:
# kill off existing pmlogger
$VERBOSE && $PCP_ECHO_PROG $PCP_ECHO_N "Terminating
for sig in INT HUP KILL
$VERBOSE && $PCP_ECHO_PROG $PCP_ECHO_N " SIG$sig ...""$PCP_ECHO_C"
eval $KILL -s $sig $pid
[ "`_check_pid $pid`" = "" ] && break
Now SIGHUP is "start a new volume" in pmlogger, SIGINT is "exit".
Is that SIGHUP supposed to be there? Seems pretty random as to
whether it will ever get called. Should we flush first? (SIGUSR1)
Was that the original intention there? SIGINT just unlinks control
files and then exits... seems like maybe we should do an flush too?
(IOW should I change the signal list to "flush, exit, force-exit"?)
More information about the pcp