[kdb] [PATCH] Add support for USB Keyboard attached to UHCI in KDB

[Martin Hicks]

On Tue, May 26, 2009 at 10:32:38AM +0200, Matthieu Fertré wrote:
> Hi,
> 
> here is an update of patch from Konstantin Baydarov <kbaidarov at ru.mvista.com>.
> 
> The patch was originally posted here:
> http://oss.sgi.com/archives/kdb/2008-02/msg00006.html
> 
> This version has been tested over kdb-v4.4-2.6.30-rc2-*-2.patch and works for
> me :-)
> I have not testing building it as a module nor with keyboard attached with
> EHCI or OHCI, thus it may be broken by the patch.

Doesn't compile for me against the latest git tree (2.6.30-rc7):

  CC      drivers/hid/usbhid/hid-core.o
drivers/hid/usbhid/hid-core.c: In function ‘hid_probe’:
drivers/hid/usbhid/hid-core.c:1201: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘usb_hcd_get_hc_keyboard_attach’
drivers/hid/usbhid/hid-core.c:1201: error: implicit declaration of function ‘usb_hcd_get_hc_keyboard_attach’
drivers/hid/usbhid/hid-core.c:1201: error: expected expression before ‘struct’
drivers/hid/usbhid/hid-core.c:1203: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘usb_hcd_get_hc_keyboard_detach’
drivers/hid/usbhid/hid-core.c:1202: warning: ISO C90 forbids mixed declarations and code
drivers/hid/usbhid/hid-core.c:1203: error: implicit declaration of function ‘usb_hcd_get_hc_keyboard_detach’
drivers/hid/usbhid/hid-core.c:1203: error: expected expression before ‘struct’
drivers/hid/usbhid/hid-core.c:1211: error: too many arguments to function ‘kdb_usb_keyboard_attach’
make[3]: *** [drivers/hid/usbhid/hid-core.o] Error 1
make[2]: *** [drivers/hid/usbhid] Error 2
make[1]: *** [drivers/hid] Error 2
make: *** [drivers] Error 2


Is there any way you can test as a module and make sure that EHCI still
works?  There were many machines that had both EHCI and UHCI
controllers.

thanks
mh