[PATCH] Add support for USB Keyboard attached to UHCI
Aaron Young
ayoung at engr.sgi.com
Fri Jan 11 09:16:31 PST 2008
>
> Aaron Young wrote:
>
> Hi Aaron and Konstantin,
>
> >
> >
> >
> > I guess I'm good with it. Couple of nits:
> >
> > 1. The routine kdb_uhci_keyboard_urb() is really not uhci specific
> > and so could be renamed to simply kdb_keyboard_urb(). Or
>
> We now have three copies of kdb_usb_kdbs[], kdb_usb_keycode[], and
> kdb_uhci_keyboard_urb().
>
> We need separate kdb_uhci_keyboard_urb() because we have three arch-
> dependent kdb_usb_kbds[]. My brief examination seems to indicate
> they are the same. Do we need to have arch-depedent kdb_usb_kbds[]?
> Also, do we need three copies of kdb_usb_keycode[]?
I see no reason off-hand why we would require arch-independent version
of these routines/structs.
---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
More information about the kdb
mailing list