[patch] Fix some problem between kdb and kdump
kaos at sgi.com
Thu May 31 17:37:19 PDT 2007
Takenori Nagano (on Thu, 31 May 2007 16:37:59 +0900) wrote:
>kdb has some problem to use with kdump.
>This patch fixes some of them.
>1) We can't use kdb when machine panicked.
>crash_kexec() is called before notifier_call_chain(&panic_notifier_chain)=
>This patch makes KDB_ENTER() is called before crash_kexec().
Both KDB and crash_kexec should be using the panic_notifier_chain, with
KDB having a higher priority than crash_exec. The whole point of
notifier chains is to handle cases like this, so we should not be
adding more code to the panic routine.
The real problem here is the way that the crash_exec code is hard coded
into various places instead of using notifier chains. The same issue
exists in arch/ia64/kernel/mca.c because of bad coding practices from
>2) We can't take a kdump when KDB_FLAG is set CATASTROPHIC.
>kdb_do_dump() does not support kdump.
>This patch makes machine_kexec() is called from kdb_do_dump().
Ugly. All the code for selecting which dump to take (lkcd, kexec,
anything else) should be in a common kernel routine that anybody can
call. It should not be just in KDB.
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
More information about the kdb