A small fix.

Keith Owens kaos at sgi.com
Tue Jun 25 19:12:51 PDT 2002


On Tue, 25 Jun 2002 17:24:00 -0700, 
Matthew Dobson <colpatch at us.ibm.com> wrote:
>This patch gets stack backtracing to work

That patch is fine.

>and also allows CPU switching on our 
>NUMA-Q hardware.

>diff -Nur linux-2.5.9-van+kdb/arch/i386/kernel/smp.c linux-2.5.9-kdb/arch/i386/kernel/smp.c
>--- linux-2.5.9-van+kdb/arch/i386/kernel/smp.c	Mon Jun 24 11:33:51 2002
>+++ linux-2.5.9-kdb/arch/i386/kernel/smp.c	Tue Jun 11 13:59:47 2002
>@@ -236,7 +237,15 @@
> 			 * program the ICR 
> 			 */
> 			cfg = __prepare_ICR(0, vector);
>-			
>+
>+#ifdef	CONFIG_KDB
>+	if (vector == KDB_VECTOR) {
>+		/*
>+		 * Setup KDB IPI to be delivered as an NMI
>+		 */
>+		cfg = (cfg&~APIC_VECTOR_MASK)|APIC_DM_NMI;
>+	}
>+#endif	/* CONFIG_KDB */
> 			/*
> 			 * Send the IPI. The write to APIC_ICR fires this off.
> 			 */

There are three calls to __prepare_ICR() in smp.c.  kdb already patches
__send_IPI_shortcut(), your patch updates send_IPI_mask_sequence.  What
about send_IPI_mask_bitmask, does that need to be tweaked as well?




More information about the kdb mailing list