Mail Archive Search: <+subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*xfstests\:\s+MKFS_OPTIONS\s+is\s+not\s+being\s+reinitialized\s*$/>

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*xfstests\:\s+MKFS_OPTIONS\s+is\s+not\s+being\s+reinitialized\s*$/: 5 ]

Total 5 documents matching your query.

1. xfstests: MKFS_OPTIONS is not being reinitialized (score: 1): Author: Boris Ranto <branto@xxxxxxxxxx>; Date: Wed, 17 Nov 2010 16:49:58 +0100; Test case 223 constantly fails because the variable carrying mkfs options is not being reinitialized. Test calls function _scratch_mkfs_geom repeatedly in for loop without cleaning the MKFS_OPTIONS v; /archives/xfs/2010-11/msg00275.html (8,407 bytes)
2. Re: xfstests: MKFS_OPTIONS is not being reinitialized (score: 1): Author: Eric Sandeen <sandeen@xxxxxxxxxxx>; Date: Wed, 17 Nov 2010 10:30:05 -0600; Thanks! I wonder though ... should we just invoke _scratch_mkfs with the geom options, and leave MKFS_OPTIONS intact? That way we could still specify custom options in the environment. OTOH they migh; /archives/xfs/2010-11/msg00276.html (9,971 bytes)
3. Re: xfstests: MKFS_OPTIONS is not being reinitialized (score: 1): Author: Dave Chinner <david@xxxxxxxxxxxxx>; Date: Thu, 18 Nov 2010 15:44:40 +1100; That'll drop any custom mkfs options on the floor for that test. Perhaps rather than using MKFS_OPTIONS, this should call scratch_mkfs directly with these as extra options, similar to the way _scratc; /archives/xfs/2010-11/msg00288.html (10,217 bytes)
4. Re: xfstests: MKFS_OPTIONS is not being reinitialized (score: 1): Author: Boris Ranto <branto@xxxxxxxxxx>; Date: Thu, 18 Nov 2010 12:40:36 -0500 (EST); If I remember it right this would not work because MKFS_OPTIONS already contained -bsize=4096 at the beginning of the test and if another -b size=$blocksize would be added to the options mkfs would f; /archives/xfs/2010-11/msg00300.html (11,003 bytes)
5. Re: xfstests: MKFS_OPTIONS is not being reinitialized (score: 1): Author: Eric Sandeen <sandeen@xxxxxxxxxxx>; Date: Thu, 18 Nov 2010 14:00:31 -0600; I thought about that too, but I'm worried about some options clashing. *nod* I think I'm ok with it the way it is. FWIW, I committed it yesterday ... We can change further if needed though, of course; /archives/xfs/2010-11/msg00302.html (12,140 bytes)

Current List: 1 - 5
Page: [1]