Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*some\s+bluetooth\s+fixes\s*$/: 26 ]

Total 26 documents matching your query.

1. some bluetooth fixes (score: 1)
Author: d@xxxxxx>
Date: Fri, 6 Feb 2004 05:00:42 +0100
While reading bluetooth code I noticed some bugs and potential overflows. Also I commented one ref-counting bug. Patch against 2.6.2. -Andi diff -u linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c-o lin
/archives/netdev/2004-02/msg00106.html (14,274 bytes)

2. Re: some bluetooth fixes (score: 1)
Author: <yoshfuji@xxxxxxxxxxxxxx>
Date: Fri, 06 Feb 2004 15:58:32 +0100
Hi Andi, thanks for looking at it. Same applies to 2.4, right? The same should apply to net/bluetooth/bnep/sock.c Why should hdev go away? Why 2*PAGE_SIZE in this case? What is different? Regards Mar
/archives/netdev/2004-02/msg00115.html (11,694 bytes)

3. Re: some bluetooth fixes (score: 1)
Author: id S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 07 Feb 2004 00:30:08 +0100
Hi Andi, this part is wrong, because it is not an error case. It is success and the refcount must stay increased. Regards Marcel
/archives/netdev/2004-02/msg00127.html (9,195 bytes)

4. Re: some bluetooth fixes (score: 1)
Author: avid S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 6 Feb 2004 15:34:01 -0800
Marcelo/Andi, I assume you guys will work things out and send me a final patch? Thanks.
/archives/netdev/2004-02/msg00131.html (8,487 bytes)

5. Re: some bluetooth fixes (score: 1)
Author: avid S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 07 Feb 2004 00:46:05 +0100
Hi Dave, I already splitted Andi's patch into smaller parts and I wait for the answers to my questions. I also have some other fixes in the queue, so you will get a number of patches ;) Regards Marce
/archives/netdev/2004-02/msg00132.html (8,759 bytes)

6. Re: some bluetooth fixes (score: 1)
Author: David Stevens <dlstevens@xxxxxxxxxx>
Date: Sat, 7 Feb 2004 03:24:28 +0100
Probably. I haven't looked at 2.4. Because the skbuff is queued, but there is no reference count to keep the device around. I wasn't 100% sure on that, so I just commented it. Feel free to remove if
/archives/netdev/2004-02/msg00138.html (12,010 bytes)

7. Re: some bluetooth fixes (score: 1)
Author: xxxxxxxxxxxxxxxxxx>
Date: Sat, 07 Feb 2004 12:13:31 +0100
Hi Andi, The queue itself is part of the hdev structure and the only call that let hdev go away is hci_unregister_dev and this clears the queue. So I don't see a problem here. I check this. Maybe we
/archives/netdev/2004-02/msg00157.html (12,491 bytes)

8. Re: some bluetooth fixes (score: 1)
Author: tmann <marcel@xxxxxxxxxxxx>
Date: Sat, 7 Feb 2004 12:57:23 +0100
What better fits the intended use case. I don't know how many objects are expected here. Smaller is better probably. If you want to handle more objects this way you should use seq_file instead. -Andi
/archives/netdev/2004-02/msg00160.html (9,036 bytes)

9. Re: some bluetooth fixes (score: 1)
Author: / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Sat, 07 Feb 2004 17:57:48 +0100
Hi Andi, I now looked carefully through your patch and changed and added some parts to better fit into. I also fixed another RFCOMM refcount bug. Please review it, before I send it to Dave. The gener
/archives/netdev/2004-02/msg00163.html (9,635 bytes)

10. Re: some bluetooth fixes (score: 1)
Author: xxxxxxxxx>
Date: Sat, 7 Feb 2004 18:24:36 +0100
Doing size checks after the multiply is too late - they could have already overflowed. You have to check the raw value from the user. -Andi
/archives/netdev/2004-02/msg00167.html (9,256 bytes)

11. Re: some bluetooth fixes (score: 1)
Author: <chas@xxxxxxxxxxxxxxxx>
Date: Wed, 11 Feb 2004 19:55:43 +0100
Hi Andi, new patch is attached. Regards Marcel Attachment: patch Description: Text Data
/archives/netdev/2004-02/msg00290.html (9,440 bytes)

12. Re: some bluetooth fixes (score: 1)
Author: a Singhvi <niv@xxxxxxxxxx>
Date: Sun, 15 Feb 2004 00:25:13 +0100
+ if (req.conn_num * sizeof(*ci) > PAGE_SIZE * 2) + return -EINVAL; This can still overflow. It should be if (req.conn_num > (PAGE_SIZE * 2)/sizeof(*ci)) return -EINVAL -Andi
/archives/netdev/2004-02/msg00293.html (9,603 bytes)

13. Re: some bluetooth fixes (score: 1)
Author: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Date: Wed, 11 Feb 2004 21:47:01 +0100
Hi Andi, thanks for reviewing the patch again. The fixed version is only attached for control. It goes out to Dave in the next minutes. Regards Marcel Attachment: patch Description: Text document
/archives/netdev/2004-02/msg00298.html (9,951 bytes)

14. some bluetooth fixes (score: 1)
Author: Andi Kleen <ak@xxxxxxx>
Date: Fri, 6 Feb 2004 05:00:42 +0100
While reading bluetooth code I noticed some bugs and potential overflows. Also I commented one ref-counting bug. Patch against 2.6.2. -Andi diff -u linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c-o lin
/archives/netdev/2004-02/msg00847.html (14,274 bytes)

15. Re: some bluetooth fixes (score: 1)
Author: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Date: Fri, 06 Feb 2004 15:58:32 +0100
Hi Andi, thanks for looking at it. Same applies to 2.4, right? The same should apply to net/bluetooth/bnep/sock.c Why should hdev go away? Why 2*PAGE_SIZE in this case? What is different? Regards Mar
/archives/netdev/2004-02/msg00856.html (11,762 bytes)

16. Re: some bluetooth fixes (score: 1)
Author: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Date: Sat, 07 Feb 2004 00:30:08 +0100
Hi Andi, this part is wrong, because it is not an error case. It is success and the refcount must stay increased. Regards Marcel
/archives/netdev/2004-02/msg00868.html (9,263 bytes)

17. Re: some bluetooth fixes (score: 1)
Author: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 6 Feb 2004 15:34:01 -0800
Marcelo/Andi, I assume you guys will work things out and send me a final patch? Thanks.
/archives/netdev/2004-02/msg00872.html (8,643 bytes)

18. Re: some bluetooth fixes (score: 1)
Author: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Date: Sat, 07 Feb 2004 00:46:05 +0100
Hi Dave, I already splitted Andi's patch into smaller parts and I wait for the answers to my questions. I also have some other fixes in the queue, so you will get a number of patches ;) Regards Marce
/archives/netdev/2004-02/msg00873.html (8,928 bytes)

19. Re: some bluetooth fixes (score: 1)
Author: Andi Kleen <ak@xxxxxxx>
Date: Sat, 7 Feb 2004 03:24:28 +0100
Probably. I haven't looked at 2.4. Because the skbuff is queued, but there is no reference count to keep the device around. I wasn't 100% sure on that, so I just commented it. Feel free to remove if
/archives/netdev/2004-02/msg00879.html (12,164 bytes)

20. Re: some bluetooth fixes (score: 1)
Author: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Date: Sat, 07 Feb 2004 12:13:31 +0100
Hi Andi, The queue itself is part of the hdev structure and the only call that let hdev go away is hci_unregister_dev and this clears the queue. So I don't see a problem here. I check this. Maybe we
/archives/netdev/2004-02/msg00898.html (12,653 bytes)


This search system is powered by Namazu