Since very few people run xfs with dmapi enabled it seem kind of silly to force the install of the dmapi utils/libraries just for xfs dump/restore. This patch stubs out the Hsm functions and adjusts
Hi Russel, I don't understand in details the build changes but they seam to be fine. In summary if the build system can find the DMAPI lib installed it will use hsmapi_noop.c otherwise hsmapi.c. The
Vlad, why do they seem fine? So this is determined at build time...so when you're using a version of xfsdump/xfsrestore how do you know you're _not_ using one that is DMAPI-aware _before_ you get int
I'm concerned about distributions inadvertently turning off dmapi support in their xfsdump builds. An explicit ./configure switch to disable dmapi support would be better, IMHO. But either way it wou
Dean Roehrich wrote: On Fri, Aug 04, 2006 at 02:18:13PM +1000, Vlad Apostolov wrote: Hi Russel, I don't understand in details the build changes but they seam to be fine. Vlad, why do they seem fine?
Dean Roehrich wrote: On Fri, Aug 04, 2006 at 10:36:37AM -0500, Russell Cattelan wrote: I appears as if the Hsm routines are only used if the -a flag is given to xfsdump. (dump DMF dualstate files as
If libhandle can satisfy everything then that would be a suitable solution. If Russell wants this changed bad enough then I'm sure he'll get around to submitting another patch for it someday... Dean
Bill Kendall wrote: Dean Roehrich wrote: On Fri, Aug 04, 2006 at 10:36:37AM -0500, Russell Cattelan wrote: I appears as if the Hsm routines are only used if the -a flag is given to xfsdump. (dump DMF
3) Add make_handle() routine to libhandle. xfsdump's only dependencies from libdm are dm_make_handle() and dm_handle_to_fsid() (the latter of which is in libhandle as handle_to_fshandle(), I think).
Here's a patch that accomplishes #3. Turns out no libhandle changes were required. Built debian and rpm packages and verified that dmapi/libdm were not mentioned in the dependencies, and for debian t
Dean Roehrich wrote: On Fri, Aug 04, 2006 at 02:18:13PM +1000, Vlad Apostolov wrote: Hi Russel, I don't understand in details the build changes but they seam to be fine. Vlad, why do they seem fine?
Don't do that. Granted, those bits can never be changed else all of your customers will start a lynch mob and come after you. At the very least, don't allow those bits to be anonymous--copy that whol
I agree with Russell that you want cscope to tell you about every place those bits are being used, so you want those defines or at least those symbols to show up here. Having them in a comment won't
On 08/07/06 11:51, Dean Roehrich wrote: On Mon, Aug 07, 2006 at 08:52:48AM -0700, Chris Wedgwood wrote: On Mon, Aug 07, 2006 at 10:30:15AM -0500, Russell Cattelan wrote: It seems rather dangerous to
Since very few people run xfs with dmapi enabled it seem kind of silly to force the install of the dmapi utils/libraries just for xfs dump/restore. This patch stubs out the Hsm functions and adjusts
Hi Russel, I don't understand in details the build changes but they seam to be fine. In summary if the build system can find the DMAPI lib installed it will use hsmapi_noop.c otherwise hsmapi.c. The