Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*Strange\s+uses\s+of\s+netif_start_queue\s*$/: 14 ]

Total 14 documents matching your query.

1. Strange uses of netif_start_queue (score: 1)
Author: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 14:35:14 +0100
Something I noticed doing the tty work. the 6pack driver calls netif_start_queue() before it calls register_netdev. I'm curious if this is allowed ?
/archives/netdev/2005-08/msg00056.html (7,174 bytes)

2. Re: Strange uses of netif_start_queue (score: 1)
Author: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 14:27:59 +0100
As part of adding support for extended 6pack which is required by the PR 430 I've recently fixed that. It was looking suspect enough that I fixed it though I don't see any way this could do harm. Ral
/archives/netdev/2005-08/msg00057.html (8,191 bytes)

3. Re: Strange uses of netif_start_queue (score: 1)
Author: Patrick McHardy <kaber@xxxxxxxxx>
Date: Fri, 12 Aug 2005 15:33:41 +0200
All netif_start_queue does is clear_bit(...), so it is a NOP at that point. I guess it could be removed.
/archives/netdev/2005-08/msg00058.html (8,093 bytes)

4. Re: Strange uses of netif_start_queue (score: 1)
Author: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 14:39:05 +0100
To answer the fundamental question, I think netif_start_queue / netif_stop_queue should be allowed in case the driver for some reason has the desire to stop queueing of packet immediately after regis
/archives/netdev/2005-08/msg00059.html (8,601 bytes)

5. Re: Strange uses of netif_start_queue (score: 1)
Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 11:00:34 -0700 (PDT)
It's definitely a bug, and when register_netdev() happens it will just overwrite that change of state. Since the queue is not initialized yet, this could also cause a crash or hang. :-)
/archives/netdev/2005-08/msg00064.html (8,159 bytes)

6. Re: Strange uses of netif_start_queue (score: 1)
Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 11:03:20 -0700 (PDT)
I disagree. register_netdev() does not make packets start getting queued, you have to up the interface for that to start occuring. And your ->open() routine has full control over that.
/archives/netdev/2005-08/msg00065.html (8,510 bytes)

7. Re: Strange uses of netif_start_queue (score: 1)
Author: Thomas Graf <tgraf@xxxxxxx>
Date: Fri, 12 Aug 2005 20:46:05 +0200
* David S. Miller <20050812.110034.63126875.davem@xxxxxxxxxxxxx> 2005-08-12 Hmm, maybe I got something wrong but: As you say correctly, there is no way we can queue packets until the device has been
/archives/netdev/2005-08/msg00066.html (9,175 bytes)

8. Strange uses of netif_start_queue (score: 1)
Author: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 14:35:14 +0100
Something I noticed doing the tty work. the 6pack driver calls netif_start_queue() before it calls register_netdev. I'm curious if this is allowed ?
/archives/netdev/2005-08/msg00217.html (7,174 bytes)

9. Re: Strange uses of netif_start_queue (score: 1)
Author: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 14:27:59 +0100
As part of adding support for extended 6pack which is required by the PR 430 I've recently fixed that. It was looking suspect enough that I fixed it though I don't see any way this could do harm. Ral
/archives/netdev/2005-08/msg00218.html (8,257 bytes)

10. Re: Strange uses of netif_start_queue (score: 1)
Author: Patrick McHardy <kaber@xxxxxxxxx>
Date: Fri, 12 Aug 2005 15:33:41 +0200
All netif_start_queue does is clear_bit(...), so it is a NOP at that point. I guess it could be removed.
/archives/netdev/2005-08/msg00219.html (8,159 bytes)

11. Re: Strange uses of netif_start_queue (score: 1)
Author: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 14:39:05 +0100
To answer the fundamental question, I think netif_start_queue / netif_stop_queue should be allowed in case the driver for some reason has the desire to stop queueing of packet immediately after regis
/archives/netdev/2005-08/msg00220.html (8,692 bytes)

12. Re: Strange uses of netif_start_queue (score: 1)
Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 11:00:34 -0700 (PDT)
It's definitely a bug, and when register_netdev() happens it will just overwrite that change of state. Since the queue is not initialized yet, this could also cause a crash or hang. :-)
/archives/netdev/2005-08/msg00225.html (8,225 bytes)

13. Re: Strange uses of netif_start_queue (score: 1)
Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 11:03:20 -0700 (PDT)
I disagree. register_netdev() does not make packets start getting queued, you have to up the interface for that to start occuring. And your ->open() routine has full control over that.
/archives/netdev/2005-08/msg00226.html (8,630 bytes)

14. Re: Strange uses of netif_start_queue (score: 1)
Author: Thomas Graf <tgraf@xxxxxxx>
Date: Fri, 12 Aug 2005 20:46:05 +0200
* David S. Miller <20050812.110034.63126875.davem@xxxxxxxxxxxxx> 2005-08-12 11:00 Hmm, maybe I got something wrong but: As you say correctly, there is no way we can queue packets until the device has
/archives/netdev/2005-08/msg00227.html (9,284 bytes)


This search system is powered by Namazu