Mail Archive Search: <+subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*Review\:\s+ensure\s+EOF\s+writes\s+into\s+existing\s+extents\s+update\s+filesize\s*$/>

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*Review\:\s+ensure\s+EOF\s+writes\s+into\s+existing\s+extents\s+update\s+filesize\s*$/: 33 ]

Total 33 documents matching your query.

1. Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Mon, 21 May 2007 09:34:17 +1000; As reported a coupl eof times on lkml since the 2.6.22 window opened, XFS is not updating the file size corectly in all cases. This is a result of the null files fix not updating the file size when t; /archives/xfs/2007-05/msg00238.html (11,884 bytes)
2. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Chris Wedgwood <cw@xxxxxxxx>; Date: Sun, 20 May 2007 16:40:48 -0700; I've had this (well, the first version you sent to Jeremy) for a few days on a testing machine without any obvious ill effects. Once people are happy with this it should be checked to see if it needs; /archives/xfs/2007-05/msg00239.html (9,310 bytes)
3. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Mon, 21 May 2007 09:44:32 +1000; It's new code so -stable is irrelevant.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group; /archives/xfs/2007-05/msg00240.html (9,382 bytes)
4. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Timothy Shimmin <tes@xxxxxxx>; Date: Mon, 21 May 2007 16:34:26 +1000; Trying to understand how the initialisers prior to the loop are used during the loop. It looks like the initial "type" isn't used now with this change as we always assign to it near to where we acce; /archives/xfs/2007-05/msg00246.html (15,179 bytes)
5. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Tue, 22 May 2007 10:44:14 +1000; Yes. Because it's good practise - it's not obvious that it gets initialised in all cases within the loop, so lets make sure that it is.... ..... There is no difference in behaviour.... Yes. It's not; /archives/xfs/2007-05/msg00255.html (12,000 bytes)
6. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Nathan Scott <nscott@xxxxxxxxxx>; Date: Tue, 22 May 2007 11:02:59 +1000; Could you resend the patch to me please? I lost the previous copy while ruthlessly ploughing through my mail backlog. ;) cheers. -- Nathan; /archives/xfs/2007-05/msg00256.html (9,758 bytes)
7. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Tue, 22 May 2007 11:03:26 +1000; Below. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group -- fs/xfs/linux-2.6/xfs_aops.c | 23 ++++++++++++++++-- 1 file changed, 16 insertions(+), 7 deletions(-) Index: 2.; /archives/xfs/2007-05/msg00257.html (13,000 bytes)
8. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Nathan Scott <nscott@xxxxxxxxxx>; Date: Tue, 22 May 2007 14:10:14 +1000; Looks pretty good to me - xfs_convert_page has been overlooked, I think - attached patch fixes that. You also initialise iomap_valid twice inside xfs_page_state_convert now ... I reverted that to jus; /archives/xfs/2007-05/msg00258.html (10,744 bytes)
9. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Tue, 22 May 2007 16:05:59 +1000; I thought about that, then tried to trip the problem and was not successful. AFAICT, if we have multiple pages dirty and in the same state (i.e. pwrite 0 32769 to dirty 3 pages, then sync, then pwrit; /archives/xfs/2007-05/msg00259.html (12,454 bytes)
10. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Wed, 23 May 2007 10:02:13 +1000; .... Patch below, Nathan. It's passed my point tests and XFSQA... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group -- fs/xfs/linux-2.6/xfs_aops.c | 26 +++++++++++++++++-; /archives/xfs/2007-05/msg00264.html (16,375 bytes)
11. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Nathan Scott <nscott@xxxxxxxxxx>; Date: Wed, 23 May 2007 10:15:19 +1000; *nod* - looks good Dave, nice detective work there. cheers. -- Nathan; /archives/xfs/2007-05/msg00265.html (10,221 bytes)
12. Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Mon, 21 May 2007 09:34:17 +1000; As reported a coupl eof times on lkml since the 2.6.22 window opened, XFS is not updating the file size corectly in all cases. This is a result of the null files fix not updating the file size when t; /archives/xfs/2007-05/msg00573.html (11,884 bytes)
13. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Chris Wedgwood <cw@xxxxxxxx>; Date: Sun, 20 May 2007 16:40:48 -0700; I've had this (well, the first version you sent to Jeremy) for a few days on a testing machine without any obvious ill effects. Once people are happy with this it should be checked to see if it needs; /archives/xfs/2007-05/msg00574.html (9,310 bytes)
14. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Mon, 21 May 2007 09:44:32 +1000; It's new code so -stable is irrelevant.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group; /archives/xfs/2007-05/msg00575.html (9,382 bytes)
15. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Timothy Shimmin <tes@xxxxxxx>; Date: Mon, 21 May 2007 16:34:26 +1000; Trying to understand how the initialisers prior to the loop are used during the loop. It looks like the initial "type" isn't used now with this change as we always assign to it near to where we acce; /archives/xfs/2007-05/msg00581.html (15,179 bytes)
16. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Tue, 22 May 2007 10:44:14 +1000; Yes. Because it's good practise - it's not obvious that it gets initialised in all cases within the loop, so lets make sure that it is.... ..... There is no difference in behaviour.... Yes. It's not; /archives/xfs/2007-05/msg00590.html (12,000 bytes)
17. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Nathan Scott <nscott@xxxxxxxxxx>; Date: Tue, 22 May 2007 11:02:59 +1000; Could you resend the patch to me please? I lost the previous copy while ruthlessly ploughing through my mail backlog. ;) cheers. -- Nathan; /archives/xfs/2007-05/msg00591.html (9,758 bytes)
18. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Tue, 22 May 2007 11:03:26 +1000; Below. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group -- fs/xfs/linux-2.6/xfs_aops.c | 23 ++++++++++++++++-- 1 file changed, 16 insertions(+), 7 deletions(-) Index: 2.; /archives/xfs/2007-05/msg00592.html (13,000 bytes)
19. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: Nathan Scott <nscott@xxxxxxxxxx>; Date: Tue, 22 May 2007 14:10:14 +1000; Looks pretty good to me - xfs_convert_page has been overlooked, I think - attached patch fixes that. You also initialise iomap_valid twice inside xfs_page_state_convert now ... I reverted that to jus; /archives/xfs/2007-05/msg00593.html (10,744 bytes)
20. Re: Review: ensure EOF writes into existing extents update filesize (score: 1): Author: David Chinner <dgc@xxxxxxx>; Date: Tue, 22 May 2007 16:05:59 +1000; I thought about that, then tried to trip the problem and was not successful. AFAICT, if we have multiple pages dirty and in the same state (i.e. pwrite 0 32769 to dirty 3 pages, then sync, then pwrit; /archives/xfs/2007-05/msg00594.html (12,454 bytes)

Current List: 1 - 20
Page: [1] [2]