Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*Review\:\s+Don\'t\s+use\s+kmap\(\)\s+in\s+xfs_iozero\(\)\.\s*$/: 8 ]

Total 8 documents matching your query.

1. Review: Don't use kmap() in xfs_iozero(). (score: 1)
Author: David Chinner <dgc@xxxxxxx>
Date: Fri, 2 Feb 2007 16:40:44 +1100
kmap is inefficient and does scale well. kmap_atomic() is a better choice. Use the generic wrapper function instead of open coding the kmap-memset-dcache flush-kumap stuff. Suggested by Andrew Morton
/archives/xfs/2007-02/msg00008.html (8,989 bytes)

2. Re: Review: Don't use kmap() in xfs_iozero(). (score: 1)
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 2 Feb 2007 11:48:30 +0000
Looks good. Do you need the cast here? An unsigned long should be automatically demoted to an unsigned int when passing it as an argument.
/archives/xfs/2007-02/msg00010.html (8,126 bytes)

3. Re: Review: Don't use kmap() in xfs_iozero(). (score: 1)
Author: David Chinner <dgc@xxxxxxx>
Date: Sat, 3 Feb 2007 00:39:41 +1100
Even on 64 bit platforms? I just added an explicit cast as a matter of avoiding potential gcc warnings on other platforms/compiler versions. Maybe I'm just being paranoid and I can remove it? Cheers,
/archives/xfs/2007-02/msg00011.html (8,785 bytes)

4. Re: Review: Don't use kmap() in xfs_iozero(). (score: 1)
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 2 Feb 2007 18:06:14 +0000
Yes, it's fine on 64bit platforms aswell - I just built my equivalent buffer.c changes on 64bit powerpc and we have lots of similar cases all over the tree.
/archives/xfs/2007-02/msg00014.html (8,374 bytes)

5. Review: Don't use kmap() in xfs_iozero(). (score: 1)
Author: )
Date: Fri, 2 Feb 2007 16:40:44 +1100
/
/archives/xfs/2007-02/msg00144.html (8,989 bytes)

6. Re: Review: Don't use kmap() in xfs_iozero(). (score: 1)
Author: >
Date: Fri, 2 Feb 2007 11:48:30 +0000
s
/archives/xfs/2007-02/msg00146.html (8,126 bytes)

7. Re: Review: Don't use kmap() in xfs_iozero(). (score: 1)
Author: >
Date: Sat, 3 Feb 2007 00:39:41 +1100
.
/archives/xfs/2007-02/msg00147.html (8,785 bytes)

8. Re: Review: Don't use kmap() in xfs_iozero(). (score: 1)
Author: )
Date: Fri, 2 Feb 2007 18:06:14 +0000
t
/archives/xfs/2007-02/msg00150.html (8,374 bytes)


This search system is powered by Namazu