- 1. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: jamal <hadi@xxxxxxxxxx>
- Date: Thu, 02 Jun 2005 08:26:46 -0400
- What is the point of making the driver "smarter"? Recall, the algorithm used to schedule the netdevices is based on an extension of Weighted Round Robin from Varghese et al known as DRR (ask gooogle
- /archives/netdev/2005-06/msg00024.html (11,454 bytes)
- 2. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: Stephen Hemminger <shemminger@xxxxxxxx>
- Date: Thu, 2 Jun 2005 10:30:52 -0700
- In fact, since the default weighting should be based on the amount of cpu time expended per frame rather than link speed. The point is that a more "heavy weight" driver shouldn't starve out all the o
- /archives/netdev/2005-06/msg00032.html (12,238 bytes)
- 3. RE: RFC: NAPI packet weighting patch (score: 1)
- Author: "Ronciak, John" <john.ronciak@xxxxxxxxx>
- Date: Thu, 2 Jun 2005 14:19:55 -0700
- The DRR algorithm assumes a perfect world, where hardware resources are infinite, packets arrive continuously (or separated by very long delays), there are no bus latencies, and CPU speed is infinite
- /archives/netdev/2005-06/msg00048.html (13,988 bytes)
- 4. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: Stephen Hemminger <shemminger@xxxxxxxx>
- Date: Thu, 2 Jun 2005 14:31:26 -0700
- This is like saying each CPU vendor should write their own process scheduler for Linux. Now with NUMA and HT, it is getting almost that bad but we still try and keep it CPU neutral. For networking th
- /archives/netdev/2005-06/msg00049.html (12,663 bytes)
- 5. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
- Date: Thu, 02 Jun 2005 14:40:03 -0700 (PDT)
- I totally agree, even the mere concept of driver-centric decisions in this area is pretty bogus. I don't understand why nobody is investigating doing this stuff by generic measurements that the core
- /archives/netdev/2005-06/msg00051.html (10,473 bytes)
- 6. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: Jon Mason <jdmason@xxxxxxxxxx>
- Date: Thu, 2 Jun 2005 16:51:48 -0500
- I think there is a way for a generic driver NAPI enhancement. That is to modify the weight dependent on link speed. Here is the problem as I see it, NAPI enablement for slow media speeds causes unnee
- /archives/netdev/2005-06/msg00052.html (11,241 bytes)
- 7. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
- Date: Thu, 02 Jun 2005 15:12:12 -0700 (PDT)
- Why do this when we can adjust the weight in one spot, namely the upper level NAPI ->poll() running loop? It can measure the overhead, how many packets processed, etc. and make intelligent decisions
- /archives/netdev/2005-06/msg00054.html (10,618 bytes)
- 8. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: Robert Olsson <Robert.Olsson@xxxxxxxxxxx>
- Date: Fri, 3 Jun 2005 00:15:50 +0200
- Differentiate the meaning of weight a bit. Let weight only limit the number of pkts we deliver per ->poll Have some other mechanism or threshold to control when interrupts are to be turned on. The fi
- /archives/netdev/2005-06/msg00055.html (12,372 bytes)
- 9. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: Jon Mason <jdmason@xxxxxxxxxx>
- Date: Thu, 2 Jun 2005 17:19:46 -0500
- Yes, a much better idea to do this generically. I 100% agree with you.
- /archives/netdev/2005-06/msg00056.html (11,283 bytes)
- 10. RE: RFC: NAPI packet weighting patch (score: 1)
- Author: "Ronciak, John" <john.ronciak@xxxxxxxxx>
- Date: Thu, 2 Jun 2005 17:11:20 -0700
- I like this idea as well but I do an issue with it. How would this stack code find out that the weight is too high and pacekts are being dropped (not being polled fast enough)? It would have to check
- /archives/netdev/2005-06/msg00064.html (12,259 bytes)
- 11. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
- Date: Thu, 02 Jun 2005 17:18:12 -0700 (PDT)
- What more do you need other than checking the statistics counter? The drop statistics (the ones we care about) are incremented in real time by the ->poll() code, so it's not like we have to trigger s
- /archives/netdev/2005-06/msg00066.html (10,789 bytes)
- 12. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: jamal <hadi@xxxxxxxxxx>
- Date: Thu, 02 Jun 2005 22:32:33 -0400
- I am reading through all the emails and I think either the problem is not being clearly stated or not understood. I was going to say "or i am on crack "- but I know i am clean ;-> Heres what i think
- /archives/netdev/2005-06/msg00073.html (13,064 bytes)
- 13. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: Mitch Williams <mitch.a.williams@xxxxxxxxx>
- Date: Fri, 3 Jun 2005 10:43:32 -0700
- Well, that was me. Or at least I was the original poster on this thread. But my theory (if you can call it that) really wasn't about CPU time. I spent several weeks in our lab with the somewhat nebul
- /archives/netdev/2005-06/msg00096.html (14,993 bytes)
- 14. RE: RFC: NAPI packet weighting patch (score: 1)
- Author: "Ronciak, John" <john.ronciak@xxxxxxxxx>
- Date: Fri, 3 Jun 2005 10:40:47 -0700
- I think that there is some more confusion here. I'm talking about frames dropped by the Ethernet controller at the hardware level (no descriptor available). This for example is happening now with ou
- /archives/netdev/2005-06/msg00097.html (10,946 bytes)
- 15. RE: RFC: NAPI packet weighting patch (score: 1)
- Author: Robert Olsson <Robert.Olsson@xxxxxxxxxxx>
- Date: Fri, 3 Jun 2005 20:08:48 +0200
- It's not obvious that weight is to blame for frames dropped. I would look into RX ring size in relation to HW mitigation. And of course if you system is very loaded the RX softirq gives room for othe
- /archives/netdev/2005-06/msg00098.html (11,539 bytes)
- 16. RE: RFC: NAPI packet weighting patch (score: 1)
- Author: "Ronciak, John" <john.ronciak@xxxxxxxxx>
- Date: Fri, 3 Jun 2005 11:19:02 -0700
- With the same system (fairly high end with nothing major running on it) we got rid of the dropped frames by just reducing the weight for 64. So the weight did have something to do with the dropped f
- /archives/netdev/2005-06/msg00099.html (10,668 bytes)
- 17. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: Ben Greear <greearb@xxxxxxxxxxxxxxx>
- Date: Fri, 03 Jun 2005 11:33:00 -0700
- Ronciak, John wrote: It's not obvious that weight is to blame for frames dropped. I would look into RX ring size in relation to HW mitigation. And of course if you system is very loaded the RX softir
- /archives/netdev/2005-06/msg00100.html (12,394 bytes)
- 18. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
- Date: Fri, 03 Jun 2005 11:38:17 -0700 (PDT)
- I really don't see how changing the weight can change things in the single adapter case. When we hit the quota, we just loop and process more packets. It doesn't fundamentally change anything about h
- /archives/netdev/2005-06/msg00101.html (11,849 bytes)
- 19. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: jamal <hadi@xxxxxxxxxx>
- Date: Fri, 03 Jun 2005 14:42:30 -0400
- When you reduce the weight, the system is spending less time in the softirq processing packets before softirq yields. If this gives more opportunity to your app to run, then the performance will go u
- /archives/netdev/2005-06/msg00102.html (16,743 bytes)
- 20. Re: RFC: NAPI packet weighting patch (score: 1)
- Author: "David S. Miller" <davem@xxxxxxxxxxxxx>
- Date: Fri, 03 Jun 2005 11:49:50 -0700 (PDT)
- Exactly my thoughts as well :) In a reply I just sent out to this thread, I postulate that the jiffies check is hitting earlier with a lower weight value, a quick look at /proc/net/softnet_stat durin
- /archives/netdev/2005-06/msg00103.html (11,302 bytes)
This search system is powered by
Namazu