I think i may have missed a few spots. Thomas it would be worth creating a macro which takes flags as input as well to replace things along the lines of: nlh = NLMSG_PUT(skb, pid, seq, event, sizeof(
How about introducing NLMSG_NEW and leave NLMSG_PUT where it is? This way we could do incremental updates. If there are not too many of those NLMSG_PUT around, then it shouldnt be an issue. The first
* jamal <1117202331.6383.39.camel@xxxxxxxxxxxxxxxxxxxxx> 2005-05-27 09:58 That is what the patch does but the diff looks a bit irritating. 1) Introduce NLMSG_NEW to take flags 2) Make NLMSG_PUT call
Yikes - sorry i glossed over the patch. Dave please apply the patch i posted into your tree and then we can follow with this other stuff. Actually Thomas, you can probably apply my patch on your side
* jamal <1117206091.6383.73.camel@xxxxxxxxxxxxxxxxxxxxx> 2005-05-27 11:01 Sure, I can come up with a patchset today which will include: o the new NLMSG_NEW macro o your patch adopted to use the new N
* jamal <1117209466.6383.106.camel@xxxxxxxxxxxxxxxxxxxxx> 2005-05-27 11:57 I took your patch, converted it to use NLMSG_NEW and finished converting all the modules that you started. Yet unconverted a
Thats the patchset 1/2 and 2/2, correct? I didnt find any issues with these as far as PID extrapolation. Do you mean the two patches? Those looked fine to me; i.e its mostly the patch i posted this m
* jamal <1117242749.6251.15.camel@xxxxxxxxxxxxxxxxxxxxx> 2005-05-27 21:12 I should have written, yet unchecked. Yes, those two patches. My part comes directly out of my fingers and is only compile te
I did check netfilter, net/sched/ tcp_diag, xfrm and they do things right. Hrm - you should probably have said that in the patch text ;-> I did test the one i sent - basic things and by code inspecti
* jamal <1117244893.6251.41.camel@xxxxxxxxxxxxxxxxxxxxx> 2005-05-27 21:48 OK. I wanted to have some time for testing today without the need to resubmit the patches. ;-> I just tested both patches for
fair enough ;-> We have another problem. What tree is this against? Both patches have failures patching against latest davem and linus git trees. I am kind of distracted right now but I could fix thi
* jamal <1117296041.19563.6.camel@xxxxxxxxxxxxxxxxxxxxx> 2005-05-28 12:00 It's against my davem-pending tree which should reflect the current state of davem's tree so they _should_ apply on his side.
Now you really have to send some swiss chocolate over ;-> It still doesnt apply to Davems latest tree. Almost very close to what i do - which could be improved or you keep a few hundred trees. Jeff G
I think i may have missed a few spots. Thomas it would be worth creating a macro which takes flags as input as well to replace things along the lines of: nlh = NLMSG_PUT(skb, pid, seq, event, sizeof(