Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*Couple\s+of\s+code\s+comments\s*$/: 4 ]

Total 4 documents matching your query.

1. Couple of code comments (score: 1)
Author: Michael Nishimoto <miken@xxxxxxxxx>
Date: Tue, 24 Jul 2007 18:59:53 -0700
I've got a couple of code comments. In xfs_write, there is a call to bhv_vop_flushinval_pages(). It appears that this function call is not needed because the call to generic_file_direct_write() done
/archives/xfs/2007-07/msg00310.html (7,366 bytes)

2. Re: Couple of code comments (score: 1)
Author: David Chinner <dgc@xxxxxxx>
Date: Wed, 25 Jul 2007 13:03:18 +1000
Similar, but seeing we call generic_file_direct_write() without the i_mutex held and we don't use the generic direct I/O path locking or flushes (i.e in __blockdev_direct_IO()), we've got to do this
/archives/xfs/2007-07/msg00311.html (8,298 bytes)

3. Couple of code comments (score: 1)
Author: Michael Nishimoto <miken@xxxxxxxxx>
Date: Tue, 24 Jul 2007 18:59:53 -0700
I've got a couple of code comments. In xfs_write, there is a call to bhv_vop_flushinval_pages(). It appears that this function call is not needed because the call to generic_file_direct_write() done
/archives/xfs/2007-07/msg00673.html (7,366 bytes)

4. Re: Couple of code comments (score: 1)
Author: David Chinner <dgc@xxxxxxx>
Date: Wed, 25 Jul 2007 13:03:18 +1000
Similar, but seeing we call generic_file_direct_write() without the i_mutex held and we don't use the generic direct I/O path locking or flushes (i.e in __blockdev_direct_IO()), we've got to do this
/archives/xfs/2007-07/msg00674.html (8,298 bytes)


This search system is powered by Namazu