[ moving from linux-kernel to correct mailing list... ] Czesc Dawid, Can you assign QoS schedulers and classifiers successfully to eth0 or some other non ipip device? Does it work with 'tunl0' instea
Actually this may be a result of the recent tweak to the scheduler code that seems to be in 2.6.2. The fix seems to fix the off by one in pfifo. cheers, jamal
What the heck, heres a patch (maybe it ll teach that poster to post to netdev instead of lk ;->). Not tested not even compiled but looks fine. ipip was always broken; the pfifo off by one fix in 2.6
More complete patch attached for other broken tunnel devices. Note the bug exists in 2.4 as well but is masquareded by a boundary bug in pfifo. cheers, jamal Attachment: p1 Description: Text document
All the alloc_netdev() types of calls dont set this - so default is zero. Maybe we could move it there. 100 seems to be what a lot of 10/100 ether devices set things to be. Note that ifconfig and ip
I think i misunderstood you - you are saying maybe it was not a bug after all in pfifo, right? i.e the off by one is ok. I suppose you could look at it that way; i am just baffled that tunnels worked
No, you understood me the first time. I am saying, the PFIFO fix was correct. And therefore if we are to preserve the tunnel device behavior precisely to what happened before the PFIFO fix we must se
Great, here is the patch I am testing now. BTW, you missed fixing up the xxx0 device in each of these things. == net/ipv4/ip_gre.c 1.34 vs edited == -- 1.34/net/ipv4/ip_gre.c Tue Oct 28 01:13:14 2003
Thanks for spotting this. Another way to view this is that configurations that, while nonsensical, used to send packets properly no longer do. However, I do agree with you, and we should not promote
On second thought: Dawid noticed that SFQ and RED appear immune to this problem (i think any non classful qdisc would exhibit same behavior). Maybe we should allow for this behavior for consistency.
I don't know how wise this tx_queue_len fiddling is. With this, if user modifies tx_queue_len himself, on ifdown this configuration change is lost if user sets it explicitly to '1'. See? In fact you
David S. Miller wrote: I don't know how wise this tx_queue_len fiddling is. With this, if user modifies tx_queue_len himself, on ifdown this configuration change is lost if user sets it explicitly to
David S. Miller wrote: On Sun, 15 Feb 2004 11:30:05 +0100 Patrick McHardy <kaber@xxxxxxxxx> wrote: I guess he meant something like this, but I still think it encourages broken configurations in combi
[ moving from linux-kernel to correct mailing list... ] Czesc Dawid, Can you assign QoS schedulers and classifiers successfully to eth0 or some other non ipip device? Does it work with 'tunl0' instea