The whole machinery to wait on I/O completion is related to the I/O path and should be there instead of in xfs_vnode.c. Also give the functions more descriptive names. Signed-off-by: Christoph Hellwi
I'm not sure that "xfs_ioend_..." is the best name - it looks slightly weird in some of the callers' contexts. Just dropping the "end" out of the names makes the code read much better (i.e. xfs_io_wa
xfs_ioend_* wasn't my first choice either. I first did xfs_iowait/xfs_iowake, but that clashes with the buffercache. And having names just different by an underscore doesn't seem good either. Any oth
Ah, so it does. but: Perhaps we should kill that define and just use xfs_buf_iowait(bp) because it documents that we really are waiting on a specific object.... Then maybe we can use xfs_data_iowake/
The whole machinery to wait on I/O completion is related to the I/O path and should be there instead of in xfs_vnode.c. Also give the functions more descriptive names. Signed-off-by: Christoph Hellwi
I'm not sure that "xfs_ioend_..." is the best name - it looks slightly weird in some of the callers' contexts. Just dropping the "end" out of the names makes the code read much better (i.e. xfs_io_wa
xfs_ioend_* wasn't my first choice either. I first did xfs_iowait/xfs_iowake, but that clashes with the buffercache. And having names just different by an underscore doesn't seem good either. Any oth
Ah, so it does. but: Perhaps we should kill that define and just use xfs_buf_iowait(bp) because it documents that we really are waiting on a specific object.... Then maybe we can use xfs_data_iowake/