This ioctl copies kernel data to the user, so we must have a compat helper to copy it out to the 32-bit structure; the current code had it backward, and translated the 32-bit arg to 64-bit, and calle
struct xfs_mount *mp, please Any reason you only allocate a xfs_fsop_geom_v1_t on stack? Just allocating a xfs_fsop_geom_t even if you don't use it would be cleaner.
This ioctl copies kernel data to the user, so we must have a compat helper to copy it out to the 32-bit structure; the current code had it backward, and translated the 32-bit arg to 64-bit, and calle
struct xfs_mount *mp, please Any reason you only allocate a xfs_fsop_geom_v1_t on stack? Just allocating a xfs_fsop_geom_t even if you don't use it would be cleaner.
This ioctl copies kernel data to the user, so we must have a compat helper to copy it out to the 32-bit structure; the current code had it backward, and translated the 32-bit arg to 64-bit, and calle
struct xfs_mount *mp, please Any reason you only allocate a xfs_fsop_geom_v1_t on stack? Just allocating a xfs_fsop_geom_t even if you don't use it would be cleaner.