Allows changing of device name via rtnetlink. Last bit needed to do full link configuration via rtnetlink. Signed-off-by: Thomas Graf <tgraf@xxxxxxx> diff -Nru linux-2.6.9-rc1-bk15.orig/include/linux
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ <20040910.230038.322907649.yoshfuji@xxxxxxxxxxxxxx> 2004-09-10 23:00 Thanks for the hint. Allows changing of device name via rtnetlink. Last bit needed to do full li
This does not work, because you don't return the new name to user space. If the new name is a pattern, such as "eth%d" or "wlan%d", you absolutely need to return the new instanciated device name to u
* Jean Tourrilhes <20040910195003.GA13912@xxxxxxxxxxxxxxxxxx> 2004-09-10 12:50 The ifindex stays the same, therefore the user space application can simply dump the link list and fetch the new interfa
* Jean Tourrilhes <20040910201302.GA16556@xxxxxxxxxxxxxxxxxx> 2004-09-10 13:13 Oh, I didn't realize that, can you enlighten me? I can think of 2 ways implementing this: 2) Implement NETDEV_CHANGE, I
Do you have any info on NETDEV_CHANGE, I've got a potential use for it. (By the way, there are other ways to do it, but if NETDEV_CHANGE is the proposed standard, I might as well use it). Jean
* Jean Tourrilhes <20040910203203.GA17078@xxxxxxxxxxxxxxxxxx> 2004-09-10 13:32 Currently call_netdevice_notifiers is called and sends out a RTM_NEWLINK message with the new interface name to everyone
I missed the RTM_NEWLINK part. It is easier to just keep it that way and make sure it is well documented as so. It may not be trivial (as an example all the inetdev name attributes change - look at i
* jamal <1094857082.1041.19.camel@xxxxxxxxxxxxxxxx> 2004-09-10 18:58 I agree, most applications will hold a cache of all links, like iproute2 is doing, and just update the cache. There is one remaini
notify via ioctls is still needed. Are you changing MTU and NAME at the same time? Valid to receive the two updates i would think in that case. cheers, jamal
* jamal <1094868070.1042.77.camel@xxxxxxxxxxxxxxxx> 2004-09-10 22:01 Possibly, I change everything the user requests me to do. That's not the problem, the problem is that you may receive more updates
Ok, this doesnt sound right. Not necessary to send all those updates. do_setlink was doing the right thing before your patch. It was announcing the change of addresses (broadcast, etc). You introduce
* jamal <1094932793.2344.82.camel@xxxxxxxxxxxxxxxx> 2004-09-11 15:59 OK, however I'd prefer to invert the concept. See patch below. This would send out the following updates: ififlags - NETDEV_(UP|DO
Guess it wont make difference in number of lines of code, so fine. This one is sort of grey area. Sigh. In any case, i think that this is ok for now. So patch should go in - we can revisit the whole