With this the driver supports the ethtool_ops {get,set}_msglvl, {get,set}_settings, get_stats, get_link, and nway_reset. Patch is tested with a 3c905-TX and a3c905B-TX NIC. Signed-off-by: Steffen Kla
I tried to use ethtool_op_get_link, but then ethtool reports Link detected: yes It does not matter wether the cable is connected or not. Unlike the other drivers, the 3c59x locks with spin_lock_bh in
Thus my comment "3c59x should properly use netif_carrier_{on,off}" :) Insufficient. 3c59x uses register windows, and you do not lock between setting the window and using the window. Jeff
With this the driver supports the ethtool_ops {get,set}_msglvl, {get,set}_settings, get_stats, get_link, and nway_reset. Patch is tested with a 3c905-TX and a3c905B-TX NIC. Signed-off-by: Steffen Kla
I tried to use ethtool_op_get_link, but then ethtool reports Link detected: yes It does not matter wether the cable is connected or not. Unlike the other drivers, the 3c59x locks with spin_lock_bh in
Thus my comment "3c59x should properly use netif_carrier_{on,off}" :) Insufficient. 3c59x uses register windows, and you do not lock between setting the window and using the window. Jeff