Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\s+2\/2\]\s+xfs\:\s+stop\s+using\s+kmalloc\s+in\s+xfs_buf_get_noaddr\s*$/: 16 ]

Total 16 documents matching your query.

1. [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 7 Mar 2007 11:13:24 +0100
Currently xfs_buf_get_noaddr allocates memory using kmem_alloc which can end up either in kmalloc or vmalloc and assigns it to the buffer. This patch changes it to allocate individual pages and if th
/archives/xfs/2007-03/msg00023.html (13,222 bytes)

2. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Shailendra Tripathi <stripathi@xxxxxxxxx>
Date: Wed, 07 Mar 2007 17:44:24 +0530
Hi Christoph, Did you do some testing for recovery when end of the physical log is seen ? When you will be dealing with striped ICLOG buffers or big sized ICLOGs, header size might range from 512 to
/archives/xfs/2007-03/msg00026.html (14,302 bytes)

3. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 7 Mar 2007 13:38:24 +0100
I ran xfsqa over it, which should catch this case. I should have made my wording more clear, we always do PAGE_SIZE + buffer allocations. After XFS_BUF_SETP_PTR the actually used buffer might be smal
/archives/xfs/2007-03/msg00027.html (9,819 bytes)

4. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 7 Mar 2007 18:15:47 +0100
It's not actually about beeing safe - any allocation is still safe with this patch. The issue is just that we waste memory because we round up allocations to the next page size. The power of two bit
/archives/xfs/2007-03/msg00029.html (9,320 bytes)

5. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Michael Nishimoto <miken@xxxxxxxxx>
Date: Wed, 07 Mar 2007 09:04:53 -0800
Incore log buffers are not always a power of two of the page size. In particular, when xfs is running over software raid devices, the log buffers are allocated to match the size of a stripe. However,
/archives/xfs/2007-03/msg00030.html (14,949 bytes)

6. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 9 Mar 2007 12:55:11 +0100
Ed Cashin found a bug in the error handling code for the case where a page allocation fails. Here's the updated version: Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c == -- linux-2.6.orig/fs/xfs/linux-
/archives/xfs/2007-03/msg00038.html (12,794 bytes)

7. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Timothy Shimmin <tes@xxxxxxx>
Date: Tue, 13 Mar 2007 11:08:29 +1100
--On 9 March 2007 12:55:11 PM +0100 Christoph Hellwig <hch@xxxxxx> wrote: Ed Cashin found a bug in the error handling code for the case where a page allocation fails. Here's the updated version: Ind
/archives/xfs/2007-03/msg00045.html (10,783 bytes)

8. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Sat, 17 Mar 2007 01:36:17 +0100
No, I was missing something :) Here's the updated version: Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c == -- linux-2.6.orig/fs/xfs/linux-2.6/xfs_buf.c 2007-03-16 15:32:20.000000000 +0100 +++ linux-2
/archives/xfs/2007-03/msg00108.html (13,731 bytes)

9. [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 7 Mar 2007 11:13:24 +0100
Currently xfs_buf_get_noaddr allocates memory using kmem_alloc which can end up either in kmalloc or vmalloc and assigns it to the buffer. This patch changes it to allocate individual pages and if th
/archives/xfs/2007-03/msg00253.html (13,222 bytes)

10. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Shailendra Tripathi <stripathi@xxxxxxxxx>
Date: Wed, 07 Mar 2007 17:44:24 +0530
Hi Christoph, Did you do some testing for recovery when end of the physical log is seen ? When you will be dealing with striped ICLOG buffers or big sized ICLOGs, header size might range from 512 to
/archives/xfs/2007-03/msg00256.html (14,302 bytes)

11. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 7 Mar 2007 13:38:24 +0100
I ran xfsqa over it, which should catch this case. I should have made my wording more clear, we always do PAGE_SIZE + buffer allocations. After XFS_BUF_SETP_PTR the actually used buffer might be smal
/archives/xfs/2007-03/msg00257.html (9,819 bytes)

12. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 7 Mar 2007 18:15:47 +0100
It's not actually about beeing safe - any allocation is still safe with this patch. The issue is just that we waste memory because we round up allocations to the next page size. The power of two bit
/archives/xfs/2007-03/msg00259.html (9,320 bytes)

13. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Michael Nishimoto <miken@xxxxxxxxx>
Date: Wed, 07 Mar 2007 09:04:53 -0800
Incore log buffers are not always a power of two of the page size. In particular, when xfs is running over software raid devices, the log buffers are allocated to match the size of a stripe. However,
/archives/xfs/2007-03/msg00260.html (14,949 bytes)

14. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 9 Mar 2007 12:55:11 +0100
Ed Cashin found a bug in the error handling code for the case where a page allocation fails. Here's the updated version: Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c == -- linux-2.6.orig/fs/xfs/linux-
/archives/xfs/2007-03/msg00268.html (12,794 bytes)

15. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Timothy Shimmin <tes@xxxxxxx>
Date: Tue, 13 Mar 2007 11:08:29 +1100
--On 9 March 2007 12:55:11 PM +0100 Christoph Hellwig <hch@xxxxxx> wrote: Ed Cashin found a bug in the error handling code for the case where a page allocation fails. Here's the updated version: Ind
/archives/xfs/2007-03/msg00275.html (10,783 bytes)

16. Re: [PATCH 2/2] xfs: stop using kmalloc in xfs_buf_get_noaddr (score: 1)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Sat, 17 Mar 2007 01:36:17 +0100
No, I was missing something :) Here's the updated version: Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c == -- linux-2.6.orig/fs/xfs/linux-2.6/xfs_buf.c 2007-03-16 15:32:20.000000000 +0100 +++ linux-2
/archives/xfs/2007-03/msg00338.html (13,731 bytes)


This search system is powered by Namazu