Change driver to auto-detect when the board is in a 32-bit PCI slot and avoid setting 64-bit dma mask. The module parameter method is no longer needed. Signed-off-by: Stephen Hemminger <shemminger@xx
Stephen Hemminger wrote: Change driver to auto-detect when the board is in a 32-bit PCI slot and avoid setting 64-bit dma mask. The module parameter method is no longer needed. Signed-off-by: Stephen
Andi Kleen <ak@xxxxxx> : It does but it is unstable for everybody (except Jon Mason, go figure) on amd64. Stephen, on which kind of system was this change tested ? -- Ueimor
Stephen Hemminger <shemminger@xxxxxxxx> : If the systems are 64 bit, one would need to know how the driver behaves when DAC is forced and: 1) the Netgear card is in a 32 bit slot, dma to highmem is e
Okay, the motivation was to try and get rid of the module parameter. I hate to see more parameters, and really don't like it when different drivers start to do things in different ways. Don't really
The concept of "64bit systems" is useless here anyways. Even on a 32bit system with highmem like i386 you can get >32bit addresses to deal with. One usecase for that would be sendfile() out of user s
Andi Kleen <ak@xxxxxx> : The combination "32 bit system with weird addressing mode + r8169 adapter" has accounted for 0 bug/success report so far and I do not know a single tester for it anyway. When
I did a quick test and my 2 adapters (integrated and stand-alone) fail the DAC test. + if ((sizeof(dma_addr_t) > 4) && + (RTL_R32(Config2) & (1<<3)) && + !pci_set_dma_mask(pdev, DMA_64BIT_MASK)) { F
Jon Mason <jdmason@xxxxxxxxxx> : Config2 can not be a replacement for "use_dac" then. It is not strictly necessary. Config2 ought to identify the 64bit slot at best. Thanks. -- Ueimor
Change driver to auto-detect when the board is in a 32-bit PCI slot and avoid setting 64-bit dma mask. The module parameter method is no longer needed. Signed-off-by: Stephen Hemminger <shemminger@xx
Andi Kleen <ak@xxxxxx> : [...] It does but it is unstable for everybody (except Jon Mason, go figure) on amd64. Stephen, on which kind of system was this change tested ? -- Ueimor