Not a problem with your patch exactly, but I was just wondering; you check here whether the sb returned from freeze_bdev is an ERR_PTR (as does lock_fs()) - but, freeze_bdev never returns an error, d
The ioctls for the generic freeze feature are below. o Freeze the filesystem int ioctl(int fd, int FIFREEZE, arg) fd: The file descriptor of the mountpoint FIFREEZE: request code for the freeze arg:
Why not just freeze_mutex? Note that we still have duplication with the bd_mount_sem. I think you should look into getting rid of it and instead do a check of the freeze_count under proper freeze_mut
inode_init_once(&ei->vfs_inode); + /* Initialize mutex for freeze. */ + mutex_init(&bdev->bd_fsfreeze_mutex); Why not just freeze_mutex? The Linux kernel has already had the name of "freezer" in the
The ioctls for the generic freeze feature are below. o Freeze the filesystem int ioctl(int fd, int FIFREEZE, arg) fd: The file descriptor of the mountpoint FIFREEZE: request code for the freeze arg:
FIFREEZE is 119, but a few lines above we have Should we be using 120 and 121 here? "freeze" is not an adequate description of what this protects. I think it's only the modification and testing of bd
No, because 'X' != 0x12... The 'X' is used because this ioctl is compatible with the XFS implementation of this feature. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsy
Now you have a reference counter of freezes which actually is pretty sensible, but also needs some documentation. What I don't understand here at all is why you do the get_super/drop_super in the alr
+#define FIFREEZE _IOWR('X', 119, int) /* Freeze */ +#define FITHAW _IOWR('X', 120, int) /* Thaw */ FIFREEZE is 119, but a few lines above we have Should we be using 120 and 121 here? As Andreas said
Christoph Hellwig wrote: On Mon, Aug 18, 2008 at 09:28:19PM +0900, Takashi Sato wrote: + down(&bdev->bd_freeze_sem); + bdev->bd_freeze_count++; + if (bdev->bd_freeze_count > 1) { + sb = get_super(bd
The ioctls for the generic freeze feature are below. o Freeze the filesystem int ioctl(int fd, int FIFREEZE, arg) fd: The file descriptor of the mountpoint FIFREEZE: request code for the freeze arg:
FIFREEZE is 119, but a few lines above we have Should we be using 120 and 121 here? "freeze" is not an adequate description of what this protects. I think it's only the modification and testing of bd
No, because 'X' != 0x12... The 'X' is used because this ioctl is compatible with the XFS implementation of this feature. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsy
Now you have a reference counter of freezes which actually is pretty sensible, but also needs some documentation. What I don't understand here at all is why you do the get_super/drop_super in the alr