Seeing you are working on xattr stuff right now, can you pick this up? (and the followup patch as well?) Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group
Btw, here's the generic acl conversion rebased ontop of these two patches. Still haven't managed to sort out the other issues with it. Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_acl.c == -- /dev/null
Hi Christoph, Looks reasonable to me - comparing xattr_permission() with attr_user_capable() and attr_trusted_capable(). Also the xattr_permission() makes more sense with its MAY_WRITE testing otherw
Tim, Seeing you are working on xattr stuff right now, can you pick this up? (and the followup patch as well?) Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group
Btw, here's the generic acl conversion rebased ontop of these two patches. Still haven't managed to sort out the other issues with it. Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_acl.c == -- /dev/null
Hi Christoph, Looks reasonable to me - comparing xattr_permission() with attr_user_capable() and attr_trusted_capable(). Also the xattr_permission() makes more sense with its MAY_WRITE testing otherw
No need for addition permission checks in the xattr handler, fs/xattr.c:xattr_permission() already does them, and in fact slightly more strict then what was in the attr_capable handlers. Signed-off-b