NACK. These macros get used by other SGI code (not merged in mainline). Their presence here has zero runtime cost, and keeps merges simpler for me, so they need to stay. Thanks for the cleanup patche
I don't think theres a valid reason to keep such dead code around. If you want these flags to stay merge the code in mainline. And while we're at that it would be nice if git tree merges would go via
In this case, yes, runtime overhead in nil. What about passing dummy credentials? What about DMAPI stubbed to errors since XFS hit mainline (at least 900 lines which can be removed)? They have runtim
Its not dead code. I will and have been happily removing dead code. Well, if it makes my maintenance task more difficult without any gain whatsoever obviously thats not going to happen, sorry. Hmm -
Hi Alexey, Yes, what about it? Is there any measurable cost there? Show me, I'm interested, really. If there is, I'm sure we can do things differently to remove that. I'm starting to get a little hes
It's 100% dead code in mainline. Please don't push in new code that doesn't do anything. Sorry about the odd reference. I don't really have time to look up the changes for each TAKE message in cvsweb
Hi Christoph, No worries. Yeah, sometimes we have new folks coming on board learning the ropes, and sometimes email lists gets b0rked. We also have somewhat oddball processes here so stuff gets dropp
Sure, this wasn't a complaint by itself. I happened to me more than often enough. It's just an explanation why it's hard to timely review xfs changes. What would be even more helpfull is of course i
Actual the define with the xfs_ prefix and vowels in the identifier is used, sorry. The grepping kernel developer would be a lot happier if both identifiers were spelled either with or without the vo
NACK. These macros get used by other SGI code (not merged in mainline). Their presence here has zero runtime cost, and keeps merges simpler for me, so they need to stay. Thanks for the cleanup patche
I don't think theres a valid reason to keep such dead code around. If you want these flags to stay merge the code in mainline. And while we're at that it would be nice if git tree merges would go via
In this case, yes, runtime overhead in nil. What about passing dummy credentials? What about DMAPI stubbed to errors since XFS hit mainline (at least 900 lines which can be removed)? They have runtim
Its not dead code. I will and have been happily removing dead code. Well, if it makes my maintenance task more difficult without any gain whatsoever obviously thats not going to happen, sorry. Hmm -
Hi Alexey, Yes, what about it? Is there any measurable cost there? Show me, I'm interested, really. If there is, I'm sure we can do things differently to remove that. I'm starting to get a little hes