Updated on top of the case-insensitive filename changes: Signed-off-by: Christoph Hellwig <hch@xxxxxx> Index: linux-2.6-xfs/fs/xfs/Makefile == -- linux-2.6-xfs.orig/fs/xfs/Makefile 2008-05-21 09:59:5
Hi Christoph, Looks reasonable to me. In list_one_attr(), which looks based on attr_generic_listadd(), it does a final: which seems useless. An aside, I noticed in passing (which was in existing code
Yeah, feel free to remove it when you commit the patch. Alternatively I'll send an incremental patch once commited. No real reason, I was just keeping what was there before. But getting rid of vn_rev
Yep, I'll remove it before checkin. Okay, good to know. Good point (I didn't really look). Okay, I'll add a comment. I guess this is done to some extent by the put_listent() callback. Though, the con
Yes, the idea is to change the put_listen callback for work more like filldir. Thas is: - the callback is supplied by the xfs_attr_list caller, not set based on options - there will be an opaque obje
Oh, okay. For example, instead of setting the flags to ATTR_KERNOVAL such as in xfs_vn_listxattr when size is 0, one could just set the callback to xfs_attr_kern_list_sizes and pass it in etc... Ok.