Hi Tommy: I agree with you now that your patch is the best way to go. We should document this so that NIC drivers are told about this. Any NICs that can't process their TX rings while the carrier is
Hi Tommy: I agree with you now that your patch is the best way to go. We should document this so that NIC drivers are told about this. Any NICs that can't process their TX rings while the carrier is
Author: Tommy Christensen <tommy.christensen@xxxxxxxxx>
Date: Tue, 26 Apr 2005 23:53:16 +0200
The executive summary: Certain network drivers call netif_stop_queue() when they detect a loss of carrier. This has some unfortunate effects on the current networking stack, since packets are now bei
I remember that thread :) Thanks for chasing this up. Agreed. The idea is good. However, the implementation has a problem in it. You're relying on the watchdog which may not be there. The watchdog is
Not having a TX timeout handler doesn't mean that the driver is doing something weird. If you do a grep in drivers/net you'll find loads of drivers that don't have TX timeout handlers but their handl
Author: Tommy Christensen <tommy.christensen@xxxxxxxxx>
Date: Thu, 28 Apr 2005 01:27:57 +0200
My theory was this: Almost all drivers should be able to use the generic watchdog (and I believe most of them do). If the "TX stalled" supervision isn't appropriate for some particular driver, e.g.
You're still assuming that the hardware will continue to drain packets when the carrier goes off. This may be true for a lot of NICs, but it is certainly not universal. I am not saying that there is
Author: Tommy Christensen <tommy.christensen@xxxxxxxxx>
Date: Fri, 29 Apr 2005 11:51:48 +0200
Originally, I was afraid it could get too trigger happy, so I left this idea. Perhaps that's not such a big deal afterall. How does this look? Signed-off-by: Tommy S. Christensen <tommy.christensen@x