Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\]\s+fix\s+BUG\s+in\s+tg3_tx\s*$/: 44 ]

Total 44 documents matching your query.

1. ion (score: 1)
Author: xxxxxx>
Date: Mon, 24 May 2004 17:26:58 +1000
The tg3 transmit code assumes that tg3_tx() will never have to clean up part of an skb queued for transmit. This assumption is wrong; sometimes tg3_tx() will be called partway through an skb, which
/archives/netdev/2004-05/msg00259.html (14,394 bytes)

2. _tx (score: 1)
Author: zik@xxxxxxxxx>
Date: Mon, 24 May 2004 00:40:45 -0700
Greg, perhaps my reading of the tg3 chip docs is different from yours. The hardware is NEVER supposed to do this. Or is there an errata in some chip versions? I've never triggered that BUG() assertio
/archives/netdev/2004-05/msg00260.html (8,494 bytes)

3. _tx (score: 1)
Author: x>
Date: Mon, 24 May 2004 18:04:31 +1000
I'd like to know where you read that, because neither I nor any of the other SGI engineers who have read the Broadcom docs can find any such guarantee. The consensus here is that there is no guarante
/archives/netdev/2004-05/msg00261.html (14,976 bytes)

4. acq (score: 1)
Author: erbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 24 May 2004 10:06:34 -0700
[ Michael, the discussion here is about whether the tigon3 hardware ever partially ACK's completion of a multi-frag TX frame. I believe it never does, but Greg claims he can trigger such a case and h
/archives/netdev/2004-05/msg00286.html (11,251 bytes)

5. acq (score: 1)
Author: x>
Date: Mon, 24 May 2004 10:26:50 -0700
The producer index of completed tx packets in the status block will always be at whole packet boundaries (1 + the index of the completed packet's last fragment). Even if it is a TSO packet, it will
/archives/netdev/2004-05/msg00289.html (13,149 bytes)

6. _tx (score: 1)
Author: xx>
Date: Mon, 24 May 2004 10:33:44 -0700
Minor correction - I should have said the send BD consumer index instead of the producer index.
/archives/netdev/2004-05/msg00290.html (9,686 bytes)

7. ult (score: 1)
Author: ume Catarineu <jaume.catarineu@xxxxxxx>
Date: Tue, 25 May 2004 11:04:34 +1000
The Windows-flavoured driver you decided to replace in Linux? I agree that this code appears to implictly rely on always getting complete send ring updates. So has this driver been tested in 2.6? I d
/archives/netdev/2004-05/msg00316.html (13,635 bytes)

8. acq (score: 1)
Author: erbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 25 May 2004 10:51:01 -0700
Greg, did you see Micahel Chan's response? A Broadcom engineer is telling us "the hardware does not ACK partial TX packets." I can't think of a more reliable source for this kind of information, can
/archives/netdev/2004-05/msg00325.html (10,079 bytes)

9. _tx (score: 1)
Author: x>
Date: Tue, 25 May 2004 10:52:04 -0700
So, BTW, I'm not putting in a workaround for the partial-TX-packet ACK in tg3_tx() until we figure out why this is happening for Greg.
/archives/netdev/2004-05/msg00326.html (9,665 bytes)

10. neg (score: 1)
Author: x>
Date: Tue, 25 May 2004 13:04:24 -0700
That's right. The hw is designed to always complete tx packets on packet boundaries and not BD boundaries. The send data completion state machine will create 1 single dma descriptor and 1 host coale
/archives/netdev/2004-05/msg00334.html (10,917 bytes)

11. ort (score: 1)
Author:
Date: Wed, 26 May 2004 10:12:17 +1000
Yes I did. I've been working towards gathering data for a reply. I can think of one: actual observation of the card in action in the field. Experiment trumps theory. To this end, I instrumented the d
/archives/netdev/2004-05/msg00336.html (11,551 bytes)

12. 6.6 (score: 1)
Author: xxxx>
Date: Wed, 26 May 2004 10:54:29 +1000
I believe the SGI-branded cards ship with firmware fixes beyond simply changing the PCI ids. Also, AFAIK it dates from about the time of the TSO experiments. Can you check if that firmware has the is
/archives/netdev/2004-05/msg00338.html (12,246 bytes)

13. _tx (score: 1)
Author: xxxxxxxxxxxxx>
Date: Tue, 25 May 2004 18:22:23 -0700
TSO firmware is downloaded by the driver and not shipped with the card. tg3 is using TSO firmware version 1.4.0 which is the latest for 5703 and 5704. Michael
/archives/netdev/2004-05/msg00339.html (8,990 bytes)

14. en. (score: 1)
Author: xxxxxxxxxx>
Date: Thu, 27 May 2004 02:04:43 +1000
On a related note, is there a good reason why the tg3 driver uses the on-chip SRAM send ring by default instead of the host send ring? This seems like it would dramatically increase the PIO load on t
/archives/netdev/2004-05/msg00348.html (10,044 bytes)

15. =) (score: 1)
Author: .curtis@xxxxxxxxxxxxx>
Date: Wed, 26 May 2004 10:43:10 -0700
I can only speak for the Broadcom bcm5700 driver. We used to use NIC send BDs by default before zero copy transmit and TSO were implemented in the kernel. Using only one BD per packet at that time,
/archives/netdev/2004-05/msg00351.html (9,288 bytes)

16. _tx (score: 1)
Author: xxx
Date: Wed, 26 May 2004 11:01:21 -0700
Good question. It actually results in better performance to use PIOs to the chip to write the TXD descriptors. You may be skeptical about this but it cannot be denied that it does result in lower lat
/archives/netdev/2004-05/msg00352.html (9,957 bytes)

17. _tx (score: 1)
Author: x>
Date: Wed, 26 May 2004 11:47:14 -0700
Ok, I'll make it use DMA tx descriptors by default. The checking for cases where we can't do on-chip TX desciptors I'll keep around (albeit commented out) just in case we allow this again in the futu
/archives/netdev/2004-05/msg00353.html (10,034 bytes)

18. ink (score: 1)
Author: Shirley Ma <xma@xxxxxxxxxx>
Date: Thu, 27 May 2004 09:47:33 +1000
Actually I am skeptical. I suspect the performance difference is dependent on chipset and load. In the case I'm looking at (multiple NIC NFS read loads) there would be 7 to 10 32-bit PIOs emitted per
/archives/netdev/2004-05/msg00376.html (10,886 bytes)

19. _tx (score: 1)
Author: x>
Date: Wed, 26 May 2004 16:52:38 -0700
Did you read my other email? I already made the change globally in my sources. tg3 will always use host send rings now.
/archives/netdev/2004-05/msg00377.html (9,562 bytes)

20. _tx (score: 1)
Author: anks <gnb@xxxxxxx>
Date: Thu, 27 May 2004 09:50:08 +1000
Ah, it's precisely the zero copy case I'm interested in. I've measured 2 to 3 BDs per packet under my load. Greg. -- Greg Banks, R&D Software Engineer, SGI Australian Software Group. I don't speak fo
/archives/netdev/2004-05/msg00378.html (9,523 bytes)


This search system is powered by Namazu